https://pantsbuild.org/ logo
#general
Title
# general
a

ambitious-actor-36781

10/07/2021, 6:43 AM
is this a bug?
Copy code
$ pants  --changed-since="origin/master" list                               
3rdparty:requirements.txt
build-support/deploy/base.py:lib
build-support/deploy/deploy.py:lib

$ pants  --changed-since="origin/master" --changed-dependees=transitive list
3rdparty:Cerberus
3rdparty:SQLAlchemy
3rdparty:alembic
... <everything> ...
Pants 2.7.0 Yes, requirements.txt has changed. But the actual changes in those requirements have not affected everything
h

hundreds-father-404

10/07/2021, 4:50 PM
Hey, good question! It's intentional, but agreed that it's a bit naive.
--changed-since
simply runs
git
to determine which concrete files were changed, then maps those to the owning targets. Then
--changed-dependees
finds what depends on those targets A target generated from
requirements.txt
has a dependency on that, which I think is conceptually sound. (Although that's actually being actively discussed at https://github.com/pantsbuild/pants/issues/13118 if you have any feedback) https://github.com/pantsbuild/pants/issues/11206 proposes a more nuanced
--changed-since
that could see "Did the Target actually change?"
5 Views