bitter-ability-32190
11/10/2021, 5:21 PMpants
to ignore linting/formatting/checking an entire directory tree? Our current build doesn't try and lint/fmt/check any directory trees that aren't XYZ, and for migration I'd like to keep this behavior.
Hopefully adding a handful of skip_ABC
in each BUILD
isn't the way ๐ฌrun
and test
though!hundreds-father-404
11/10/2021, 5:24 PMskip_tool
field
What's the hesitation? Definitely curious how that can be improved. Some ideas that have been thrown out:
1: Make it easier to programmatically update BUILD files
2. Add an overrides
inheritance mechanism https://docs.google.com/document/d/1bcQRJazx6ODKc0PZRUgPx_bqHc6XurpBawTMD2zhtAk/editbusy-vase-39202
11/10/2021, 5:27 PMfast-nail-55400
11/10/2021, 5:27 PM--tag
?bitter-ability-32190
11/10/2021, 5:28 PMWhat's the hesitation?There's a lot of files/dirs in the not-linted locations ๐ฌ But also there's a lot in the linted-locations. So opt-out or opt-in at the
BUILD
level is certainly doable, and one-time-cost but oof.witty-crayon-22786
11/10/2021, 5:32 PMskip_$tool
args do, but nativelyfast-nail-55400
11/10/2021, 5:33 PMwitty-crayon-22786
11/10/2021, 5:33 PMbitter-ability-32190
11/10/2021, 5:34 PMDefinitely curious how that can be improved.Pants has a config ignore.. maybe that can be extended per-tool?
[pylint].ignore=...
etc...BUILD
files to add the skip flags ๐ )hundreds-father-404
11/10/2021, 5:37 PMbitter-ability-32190
11/10/2021, 5:38 PMwitty-crayon-22786
11/10/2021, 5:39 PMbitter-ability-32190
11/10/2021, 5:40 PMwitty-crayon-22786
11/10/2021, 5:41 PMhundreds-father-404
11/10/2021, 5:41 PMwitty-crayon-22786
11/10/2021, 5:42 PMpython_sources
) or untyped (override
)clean-city-64472
11/10/2021, 5:45 PMignore_error
setting combined with ability to have config sections per module [mypy-my.module.*]
. I wonder if the other tools that are implicated have similar settings that make it easier to ignore entire directory trees.bitter-ability-32190
11/10/2021, 5:47 PMisort
does this. It's like "you told me to ignore this dir but are explicitly asking me to sort this file, so I'll sort it)
โข Pants will still be doing the work of invoking the tool IIUC, which is less-than-idealhundreds-father-404
11/10/2021, 5:48 PM