https://pantsbuild.org/ logo
#general
Title
# general
m

modern-wolf-36228

12/16/2021, 2:18 PM
The
secrets
on
docker_image()
is not on 2.9.0.dev4?
c

curved-television-6568

12/16/2021, 2:36 PM
Nope, I missed that train by a day.. 😕
Copy code
$ git show 8105b43e1
commit 8105b43e188cf283b522d24a7d57518c75c174c6
Author: Yi Cheng <wisechengyi@gmail.com>
Date:   Mon Dec 13 15:56:04 2021 -0800

    Prep 2.9.0.dev4 (#13867)
Copy code
$ git show 5e3317be8 --stat
commit 5e3317be8335bc349bc3b4444b885c70390cf8e8
Author: Andreas Stenius <andreas.stenius@svenskaspel.se>
Date:   Tue Dec 14 09:15:35 2021 +0100

    Add new `secrets` field to `docker_image`. (#13830)
😭 1
there’ll likely be a
rc
out soon, though…
m

modern-wolf-36228

12/16/2021, 2:40 PM
thanks 😢
is it bad to add the PANTS_SHA on the
pants
executable?
c

curved-television-6568

12/16/2021, 2:48 PM
No that's fine. It's enough to set the env var, if that's feasible for you.
3 Views