Edit: Solved again by using my eyes
How can I add...
# generalb
bitter-ability-32190
12/27/2021, 9:19 PMEdit: Solved again by using my eyes
How can I add VCS
extra_requirementsgit+<https://github.com/>....bitter-ability-32190
12/27/2021, 9:20 PMh
hundreds-father-404
12/27/2021, 9:21 PMAre you trying to generate a lockfile with it in particular? If so, we're trying to figure this out. VCS requirements do not work with lockfiles atm https://github.com/pantsbuild/pex/issues/1556
The workaround for now is to set that tool's
lockfile = "<none>"b
bitter-ability-32190
12/27/2021, 9:23 PMOh yeah, I see now the lockfile gets generated but not with what I expect
bitter-ability-32190
12/27/2021, 9:25 PMAlternatively I'm OK with being a bad person and monkeypatching the code, but:
If you want to write first-party plugins for other linters like Flake8, let us know on Slack.
h
hundreds-father-404
12/27/2021, 9:32 PMTo clarify, that plugin note is about writing plugins like
flake8-2020b
bitter-ability-32190
12/27/2021, 9:33 PMYeah, I could "cheat" here and make a "plugin" for
flake8👍 1
bitter-ability-32190
12/27/2021, 9:34 PM(I actually do the monkeypatching today, since our current build tooling also disallows VCS reqs. But I'm invoking
flake8h
hundreds-father-404
12/27/2021, 9:42 PMGot it. Are you able to work around this all today by disabling the lockfile and using a VCS requirement? Ack that it's suboptimal to not be able to use a lockfile. (Feedback welcomed on https://github.com/pantsbuild/pex/issues/1556 if you have any)
b
bitter-ability-32190
12/27/2021, 9:45 PMWhat's the side-effect of not using a lockfile?
h
hundreds-father-404
12/27/2021, 9:51 PMMore risk your build will break overnight if a transitive dep changes, and more risk for supply chain attack.
You can very hackily recreate a lockfile by pinning every transitive dep in
[flake8].extra_requirements--hashb
bitter-ability-32190
12/27/2021, 9:52 PM🤔 works for me I think, will try out first thing tomorrow
👍 1
bitter-ability-32190
12/27/2021, 9:53 PM(I was already pinning transitive deps, to make migrating have the fewest hiccups)
bitter-ability-32190
12/28/2021, 4:05 PMRunning
lintflake8--no=...-cleanup👀 1
bitter-ability-32190
12/28/2021, 4:20 PMYeah I'm still seeing the PyPI version in the PEX
bitter-ability-32190
12/28/2021, 4:20 PM Copy code
[flake8]
version = "flake8==4.0.1"
lockfile = "<none>"
extra_requirements.add = [
"darglint@ git+<https://github.com/thejcannon/darglint@master#egg=darglint>",
...bitter-ability-32190
12/28/2021, 4:26 PMI might still want to make a fake monkeypatch plugin, honestly. We lint test files with less error codes, and I'm not sure flake8 can handle that natively or if there's a plugin for it 😭
h
hundreds-father-404
12/28/2021, 5:57 PMHmmm I'm surprised it's not using the Git version...if you use
--no-process-cleanupunzipPEX-INFOb
bitter-ability-32190
12/28/2021, 6:00 PMThat's what I'm seeing 🤔
Let me double-check when I'm back on that branch
bitter-ability-32190
12/28/2021, 9:04 PMMust have been a red herring 🤔
👀 1
bitter-ability-32190
12/28/2021, 9:05 PMBut I'm still probably going to need a first-party plugin for monkeypatching tests error code filtering
bitter-ability-32190
12/28/2021, 9:09 PM(red herring was I was specifying the wrong branch 🤦♂️ )
👍 1
bitter-ability-32190
12/28/2021, 9:45 PMLooking at https://flake8.pycqa.org/en/latest/user/configuration.html#using-local-pluginslake8 looks like flake8 local plugins might not be too different from pylint
🚀 1
h
hundreds-father-404
12/28/2021, 9:48 PMawesome! contribution definitely welcomed, should be able to copy pasta a bit from Pylint. Read the help string in
pylint/subsystem.pyb
bitter-ability-32190
12/28/2021, 9:52 PMHehe I'll add it to my list of things I need to contribute 😈
h
hundreds-father-404
12/28/2021, 9:54 PMs/need/want to 🙂 never an expectation you contribute a particular thing
b
bitter-ability-32190
12/28/2021, 10:00 PMThe need isn't fro y'all. It's from my dayjob 🤓
➕ 1
e
enough-analyst-54434
12/29/2021, 2:18 AMI think the Pex issue is a bit off base since we aren't using Pex for this right now. I was lazy and did not file an issue, but this comment explains what happens when you use a vcs direct reference requirement today: https://github.com/pantsbuild/pants/issues/13965#issuecomment-1000483186
You get a silent failure to lock what you asked for and get a lock on the latest public version instead - if there is one.
enough-analyst-54434
12/29/2021, 2:34 AMThe bug is, specifically, demonstrated by:
Copy code
$ pex setuptools -- -c 'from pkg_resources import Requirement; req = Requirement.parse("darglint @ git+<https://github.com/thejcannon/darglint@XYZ>"); print(f"req: {req} spec: {req.specifier}")'
req: darglint@ git+<https://github.com/thejcannon/darglint@XYZ> spec:enough-analyst-54434
12/29/2021, 2:35 AMIMO we should be failing fast for this case today since we can't do what you asked.
enough-analyst-54434
12/29/2021, 2:43 AM