Got an interesting dependency resolution issue I added

Question

Got an interesting dependency resolution issue I added <https pypi org project boto3 stubs |boto3 stubs> to get better type hinting in my editor and now pants is thinking `boto3` maps to `boto3 stubs` and gets confused on imports I can go manually add this dependency since it doesn t show up in too many places but I m surprised it s getting confused I even updated my `module mapping` to try to force the resolution but it wasn t happy

high-yak-85899 · Answer

I can open a bug ticket if there s not something quick that comes to mind

high-yak-85899 · Answer

In my module I have something like ```import boto3 import click``` and dependencies is showing ``` boto3 stubs click```

high-yak-85899 · Answer

I have ```boto3==1 17 0 botocore gt =1 20 0 lt 2``` in a `requirements txt` and ```boto3 stubs gt =1 21 0 lt 2 boto3 stubs s3 ecr sts ``` in a `requirements dev txt`

high-yak-85899 · Answer

I found this <https www pantsbuild org docs python third party dependencies use modules and module mapping when the module name is not standard|here> gt If the dependency is a type stub and the default does not work set `type stub modules` on the `python requirement` target and `type stubs module mapping` on the `python requirements` and `poetry requirements` macros The default for type stubs is to strip off `types ` ` types` ` stubs` and `stubs ` So `types requests` gives type stubs for the module `requests`

high-yak-85899 · Answer

But that just seems helpful for registering a stub library with another module and not undoing the issue I m seeing

happy-kitchen-89482 · Answer

< hundreds father 404> is the expert here but he s out until Friday Let me see if I can figure it out

high-yak-85899 · Answer

Thanks Another thing I was thinking is that it would be nice if type stubs were only added for goals that actually needed them e g lint Seems inefficient to package type stubs along with a pex binary which is the impression I m getting from running `dependencies` since they ll never affect functionality

high-yak-85899 · Answer

Sounds worth a bug ticket so I ll get on that Edit <https github com pantsbuild pants issues 14513|ticket here>

happy-kitchen-89482 · Answer

Thanks

hundreds-father-404 · Answer

< high yak 85899> why define `boto3 stubs` twice ```boto3 stubs gt =1 21 0 lt 2 boto3 stubs s3 ecr sts ``` Could you do `boto3 stubs s3 ecr sts gt =1 21 0 lt 2` instead I only reproduce the issue when you have both stubs defined and it s because it triggers ambiguity with dependency inference so Pants can t figure out which you want

hundreds-father-404 · Answer

Otherwise things work for me ```diff git a src python pants util BUILD b src python pants util BUILD index 76d0a50a8 64b634564 100644 a src python pants util BUILD +++ b src python pants util BUILD 4 3 +4 6 python sources python tests name= tests + +python requirement name= boto3 requirements= boto3 +python requirement name= boto3 stubs requirements= boto3 stubs diff git a src python pants util collections py b src python pants util collections py index 0dd3e3d90 4874ba5d5 100644 a src python pants util collections py +++ b src python pants util collections py 8 7 +8 10 import collections abc import gc import math from sys import getsizeof from typing import Any Callable Iterable Iterator MutableMapping TypeVar +from typing import Any Callable Iterable Iterator MutableMapping TypeVar TYPE CHECKING + +if TYPE CHECKING + import boto3 from pants engine internals import native engine ``` ``` pants dependencies src python pants util collections py src python pants util boto3 src python pants util boto3 stubs```

hundreds-father-404 · Answer

also sorry for the superrrrrr delayed reply to this disappointed

high-yak-85899 · Answer

I didn t try the latter When you just have `boto3 stubs` it only pulls in the most common stubs which I think didn t include the specific ones I then had to call out

hundreds-father-404 · Answer

I think `boto3 stubs s3 ecr sts gt =1 21 0 lt 2` should do the trick

hundreds-father-404 · Answer

do you know if those two other users huonw and achimnol are on your team Wondering why they liked the GH issue if they have the same problem

high-yak-85899 · Answer

Not that I know of