https://pantsbuild.org/ logo
#general
Title
# general
h

hundreds-father-404

03/07/2022, 7:42 PM
A new
good first issue
that could speed up Pants a decent bit & should be approachable. https://github.com/pantsbuild/pants/issues/14719
Optimize Pants's data structures by not sorting as much (FrozenOrderedSet and FrozenDict)
1
h

happy-kitchen-89482

03/07/2022, 10:35 PM
Primary rule of optimization - profile first
It may be the case that sorting has noticeable performance impact, or it may not
A profile removes doubt
h

hundreds-father-404

03/07/2022, 10:37 PM
True, but also the sorting makes our code more complex to read. There seems to be no benefit to it. Even if the impact isn't very profound, it is wasted computation + wasted code complexity
h

happy-kitchen-89482

03/07/2022, 10:54 PM
Sure, and it may be worth doing for those reasons alone, but the priority might be lower than if it were a known performance win
3 Views