https://pantsbuild.org/ logo
#general
Title
# general
h

happy-kitchen-89482

03/22/2022, 9:25 PM
Soliciting your opinions about the
No applicable files or targets matched.
WARN log: Today when you do things like
./pants test ::
or
./pants --changed-since=main --changed-dependees=transitive test
and no test files match, you get a WARN log along the lines of
Copy code
17:18:14.39 [WARN] No applicable files or targets matched. The `test` goal works with these target types:

  * go_package
  * junit_test
  * python_test
  * scala_junit_test
  * scalatest_test
  * shunit2_test

However, you only specified targets with these target types:

  * python_source

Please specify relevant files and/or targets. Run `./pants filter --target-type=go_package,junit_test,python_test,scala_junit_test,scalatest_test,shunit2_test ::` to find all applicable targets in your project, or run `./pants filter --target-type=go_package,junit_test,python_test,scala_junit_test,scalatest_test,shunit2_test :: | xargs ./pants filedeps` to find all applicable files.
I am currently wondering whether this warning is desirable. • Arguments for it include that it may help catch cases where your Pants command did not match your intent. • Arguments against it include that the empty set is not a special case, so if "run all tests that match this spec" ends up being fulfilled vacuously then so be it. This is particularly salient for
--changed-*
or when generating command specs from other data.
👍 1
So I'm curious how many folks find this warning desirable vs want to get rid of it
1 - Keep this warning 2 - Remove this warning
3️⃣ 1
1️⃣ 1
2️⃣ 3
e

enough-analyst-54434

03/22/2022, 9:28 PM
I'm +1 to remove. Although
./pants --change-since=upstream/main fmt lint check test
works, I have to
2>/dev/null
to avoid being nannied.
b

bitter-ability-32190

03/22/2022, 9:30 PM
1️⃣ if you give me an option that disables it easily. I suppose I can add to pants warnings filter, but that's clunky Otherwise 2️⃣
1
e

enough-analyst-54434

03/22/2022, 9:30 PM
Proliferation of options and all that, but at some point it make make sense to provide more structure to our warnings and suggestions and then have a global flag
--player-level={beginner,tradesman,aggro}
~paraphrasing.
b

bitter-ability-32190

03/22/2022, 9:31 PM
It'd be an advanced option, as it's only useful to warn for users IMO
c

curved-television-6568

03/22/2022, 9:41 PM
To accomodate a growing number of features and use cases, so will options also multiply. Of course all new options should be motivated, but what I think is important is to be able to group/search/filter them logically to be manageable.
b

bitter-ability-32190

03/22/2022, 10:01 PM
It might be some set of options are only really relevant for CI. In that case Pants might benefit from a --ci flag, not different fr a grabag option like --strict for mypy
This warning filter could fall in that. The only reason I don't set it today is because I forgot it existed and it's admittedly klunky
I tried adding a
cli.alias
to do the silencing so we can control when it gets silenced, but I can't seem to get it working:
Copy code
[cli.alias]
ignore-no-targets-warning = '--ignore-warnings="No files or targets specified"'
...
Copy code
joshuacannon@CEPHANDRIUS:~/work/techlabs$ ./pants --changed-since=master test ignore-no-targets-warning
Unknown goal: ignore-no-targets-warning
joshuacannon@CEPHANDRIUS:~/work/techlabs$ ./pants ignore-no-targets-warning --changed-since=master test
Unknown goal: ignore-no-targets-warning
joshuacannon@CEPHANDRIUS:~/work/techlabs$ ./pants --changed-since=master ignore-no-targets-warning test
Unknown goal: ignore-no-targets-warning
👀 1
Also the fact that the string can change slightly stings for warnings filters:
Copy code
11:14:50.99 [WARN] No applicable files or targets matched. The `test` goal works with these target types

vs

11:15:27.02 [WARN] No files or targets specified. The `test` goal works with these target types:
Also oddly I don't think I see this behavior on
fmt
h

happy-kitchen-89482

03/24/2022, 6:44 PM
https://github.com/pantsbuild/pants/pull/14904 - proposed PR to remove this WARNing
c

curved-television-6568

03/25/2022, 9:44 AM
@bitter-ability-32190 I don’t repo your unknown goal issue. Could you have custom
.pants.rc
files in
$HOME
or
.
that trips up your configuration?
Copy code
$ ./pants ignore-no-targets-warning test
$ ./pants test ignore-no-targets-warning
Unknown flag --ignore-warnings on test scope
Did you mean to use the global --ignore-warnings? Global options must come before any goals, or after any file/target arguments.
[...]
b

bitter-ability-32190

03/25/2022, 10:17 AM
I suspect it might be due to also using a flag in conjunction. Try it with
-ldebug
as well
c

curved-television-6568

03/25/2022, 11:54 AM
Nope, works fine with
-ldebug
for me too…
🤯 1
5 Views