I seem to be bit by the same `typing_extensions` m...
# generalb
bitter-ability-32190
04/04/2022, 6:44 PMI seem to be bit by the same
typing_extensions Copy code
]
[Step 8/9] + ./pants --pants-config-files=pants.ci.toml --changed-since=origin/master --changed-dependees=transitive test
...
[Step 8/9] File "/home/buildagent/.cache/pants/setup/bootstrap-Linux-x86_64/2.11.0rc1_py38/lib/python3.8/site-packages/pants/util/dirutil.py", line 18, in <module>
[Step 8/9] from typing_extensions import Literal
[Step 8/9] ModuleNotFoundError: No module named 'typing_extensions'bitter-ability-32190
04/04/2022, 6:45 PMI have a suspicion that this only occurs when the bootstrap is done in a subprocess of an existing Python process with
typing_extensionsbitter-ability-32190
04/04/2022, 7:11 PMIf I remove
--quietpip install Copy code
Requirement already satisfied: typing-extensions==4.0.1 in /some/path/to/typing_extensions (from pantsbuild.pants==2.11.0rc1) (4.0.1) Copy code
-I, --ignore-installed Ignore the installed packages, overwriting them. This can break your system if the existing package is of a different version or was
installed with a different package manager!👀 1
bitter-ability-32190
04/04/2022, 7:18 PMbitter-ability-32190
04/04/2022, 7:21 PMbitter-ability-32190
04/04/2022, 7:27 PMI'm gonna apply my PR locally to unblock my work task. If @hundreds-father-404 or @enough-analyst-54434 or @polite-garden-50641 has a free cycle to quickly look at the PR to ensure I'm not doing something dumb I'd greatly appreciate it ❤️
👍 1
e
enough-analyst-54434
04/04/2022, 8:49 PMI took a look. Your fix is probably fine, but this is another case - for me - of no clue what's actually going on here. I never ever like that.
👍 1
b
bitter-ability-32190
04/04/2022, 8:50 PMLooks like
pipPYTHONPATHbitter-ability-32190
04/04/2022, 8:50 PMe
enough-analyst-54434
04/04/2022, 8:52 PMAh - MUCH better! So then, should PYTHONPATH just be unset? We already scrub PEX env vars to avoid contamination.
b
bitter-ability-32190
04/04/2022, 8:53 PMThat would also work
bitter-ability-32190
04/04/2022, 8:53 PMI think?
e
enough-analyst-54434
04/04/2022, 8:59 PMIt definitely would work and it would actually make sense locally. The current fix makes no sense locally as pointed out in my PR comments.
➕ 1
4 Views