Hi, is there some standard way of handling python sub-packages which aren't necessarily imported inside but the package under which these sub-packages live. These sub-packages are just a way to modularize the code base. e.g.

package
  BUILD
  __init__.py
  -- sub-pkg1
  -- sub-pkg2

then later we do say for testing

from package.sub-pkg1 import func1

pants will complain that this

package.sub-pkg1

isn't a package since it can't infer the dependency unless I explicitly add in BUILD

sub-pkg1

as dependency for

package

. Basically is there a way around providing this explicit dependency in such case.

what happens if you create

sub-pkg1/__init__.py

?

it still complains

and what are the contents of

package/BUILD

and

package/sub-pkg1/BUILD

?

if you ever need to manually add a dependency that you have a Python import statement for, it’s most likely due to not having source roots set up properly: https://www.pantsbuild.org/docs/source-roots

I didn’t see

package/sub-pkg1/BUILD

listed as a file. If that is missing, you will need a

python_sources

target in that BUILD file.

./pants tailor

can make all of the necessary

BUILD

files for you.

The import statement is not inside the

package

though. That's why pants can't infer it. This is just a way to organize code inside

package

@fast-nail-55400 yeah all the

BUILD

inside

sub-pkg

have

python_sources

where is the import statement located then?

structure of repo is something like this

package1
package2
tests

and then when I run

./pants test tests:tests

for testing

package1

and

package2

, imports inside tests are like

from package1.sub-pkg1 import func_to_test

which complains

then @witty-crayon-22786’s suggestion about checking the source root configuration in pants.toml probably applies

you can run

./pants roots

I keep running into this issue where I need to explicitly add dependency for my tests import to work if sub packages etc weren't imported inside the packages where these sub packages live. I verified source root etc. This work out of the box if I am directly running pytest though. It's able to figure out these sub packages.

ah. by default, Pants does not infer dependencies on

__init__.py

files: you can enable it with: https://www.pantsbuild.org/docs/reference-python-infer#section-inits