Hi there Favor to help us out with evaluating a proposal to

Question

Hi there Favor to help us out with evaluating a proposal to make the `name=` field less confusing amp target addresses simpler would you be willing to run this script and report back on what it says warning it may take ~3 15 minutes probably and you can t run other Pants commands while doing it

hundreds-father-404 · Answer

Instructions 1 `curl L <https gist githubusercontent com Eric Arellano 237c94dd602a3b36a72104e294167008 raw 2a248bf698659a35abbd4e571d8e6e9b244d08c1 find num owners py> | python3 ` 2 tell us the final report

hundreds-father-404 · Answer

fyi the proposal you re helping us to evaluate <https docs google com document d 1jSCJ3pwvIMg5duafsr8KmiLOO 2ARMaYCSrb8K85JQc edit heading=h qaptp4quk5bw>

hundreds-father-404 · Answer

the final report includes total of files feel free to scrub that if it s confidential the percentage is the most important part

polite-garden-50641 · Answer

~if running in python 3 8 and lower `from future import annotations` should be added at the top of the file Otherwise a TypeError occurs ~

bitter-ability-32190 · Answer

Any way you could upload the code as a gist and provide a one liner to run That d make it easier Like `curl $url | python`

bitter-ability-32190 · Answer

`curl <https pantsbuild slack com files UB2J9BQA0 F03FHQE5B5K find num owners py py>` outputs nothing I suspect due to auth

polite-garden-50641 · Answer

ah yes maybe put this in a public gist

hundreds-father-404 · Answer

updated

wide-midnight-78598 · Answer

Do you want the gdoc updated

wide-midnight-78598 · Answer

`subprocess CalledProcessError Command pants peek returned non zero exit status 1 ` Is there a pants version requirement

hundreds-father-404 · Answer

sure that saves me a step slightly smiling face

bitter-ability-32190 · Answer

FYI if you drop the ` O` you can pipe through to python

bitter-ability-32190 · Answer

```curl L <https gist githubusercontent com Eric Arellano 237c94dd602a3b36a72104e294167008 raw 37c1c01ed46f5e804d541164ecaa61b0d8bba2ff find num owners py> | python3 ```

witty-family-13337 · Answer

in our case the script crashes using Pants 2 11 when it get s to the point where it runs ` pants list go mod` with a `ResolveError No owning targets could be found for the file `go mod`` even though there is a `go mod` target in a `BUILD` file next to where the Go modules file is

hundreds-father-404 · Answer

gt Is there a pants version requirement `peek` has been supported for a while What does ` pants peek ` say when run directly in your repo

hundreds-father-404 · Answer

Thanks < witty family 13337> Asher found the same I think it might be a legit bug open mouth Workaround is to remove `check=True` from line 62 I also updated the gist w that edit

witty-family-13337 · Answer

I see I ll rerun it using the updated version

bitter-ability-32190 · Answer

can this also be multiprocessed its taking a while and 63 other cores are hungry for work P

hundreds-father-404 · Answer

Yeah for sure I don t have much direct Python multiprocessing experience tho I gotta run to get my x rays but patch definitely welcomed maybe a `git diff`

hundreds-father-404 · Answer

Cool Go issue is <https github com pantsbuild pants issues 14736> which I started fixing this weekend Thank you for the report

bitter-ability-32190 · Answer

Well I ran it ```0 owners 0 0 0 2508 1 owners 86 2 2162 2508 2 owners 4 9 124 2508 gt 2 owners 8 9 222 2508 ``` I suspect anything with gt 1 owner is an artifact of our bazle pants straddling and will be gone when we re off Bazel completely

polite-garden-50641 · Answer

Toolchain private monorepo ```0 owners 0 1 2 2065 1 owners 94 2 1946 2065 2 owners 5 7 117 2065 gt 2 owners 0 0 0 2065 ```

witty-family-13337 · Answer

our monorepo gave these results ```0 owners 0 1 2 2647 1 owners 99 0 2621 2647 2 owners 0 9 23 2647 gt 2 owners 0 0 1 2647 ```

narrow-vegetable-37489 · Answer

```0 owners 0 0 0 442 1 owners 95 9 424 442 2 owners 3 8 17 442 gt 2 owners 0 2 1 442 ``` Couldn t get the script to run on our second Pants repo yes I know Hoping to merge the two one day will see if I can fix it

hundreds-father-404 · Answer

Thank you What was the error Jonas

hundreds-father-404 · Answer

also Jonas I think we have enough data now so no worries if you don t get to it Thank you everyone for helping