https://pantsbuild.org/ logo
#general
Title
# general
h

high-yak-85899

05/19/2022, 8:38 PM
Since the length of a goal name came up the other day, is there background on why it's
generate-lockfiles
instead of something like
lock
?
👀 1
b

bitter-ability-32190

05/19/2022, 8:41 PM
ooooohhhhh
I like that
w

witty-crayon-22786

05/19/2022, 8:55 PM
because we would like to remove it entirely via https://github.com/pantsbuild/pants/issues/12014 !
npm
,
cargo
, etc automatically rewrite the lockfile if inputs have changed, unless you have asked them to fail instead… and that’s what we’re aiming for
👀 1
h

high-yak-85899

05/19/2022, 8:58 PM
oh yeah. I remember this being annoying when I was first checking out bazel where it couldn't regenerate our lockfile even though it already knew about the upstream source/had the tools capable of generating it.
That would be a very cool feature
w

witty-crayon-22786

05/19/2022, 8:59 PM
heh. unlike bazel, we do already support manipulating files within a run (for
fmt
, etc)… so it’s mostly just about not needing every single
goal
to be aware of the fact that a lockfile might change during a run
❤️ 2
c

curved-television-6568

05/20/2022, 5:47 AM
None of the above motivates the longer name imo. The history being there where more than one lockfile related goal initially, if memory serves.
2
h

hundreds-father-404

05/20/2022, 12:24 PM
that's right, I agree we should shorten to
lock
. That's a 2 line change -- we have infrastructure for deprecating a goal name
1
2 Views