Is it expected that given a Pants command line I c...
# generale
enough-analyst-54434
05/26/2022, 5:04 PMIs it expected that given a Pants command line I can no longer tack on a request for help?
enough-analyst-54434
05/26/2022, 5:04 PMI used to throw a
-h Copy code
$ ./pants --help test src/python/pants/bsp/protocol_test.py
Unknown entity: src/python/pants/bsp/protocol_test.py
$ ./pants test --help src/python/pants/bsp/protocol_test.py
Unknown entity: src/python/pants/bsp/protocol_test.py
$ ./pants test src/python/pants/bsp/protocol_test.py --help
11:00:27.87 [INFO] Completed: Run Pytest - src/python/pants/bsp/protocol_test.py:tests succeeded.
ā src/python/pants/bsp/protocol_test.py:tests succeeded in 1.10s (cached locally). Copy code
./pants help testf
fast-nail-55400
05/26/2022, 5:04 PMI think @hundreds-father-404 just made a change that impacted single-character options. Does
--helpe
enough-analyst-54434
05/26/2022, 5:05 PMNope.
h
hundreds-father-404
05/26/2022, 5:08 PMHm it should work. I'll bisect and look into this, thanks for flagging
e
enough-analyst-54434
05/26/2022, 5:09 PMOh, I'm involved so I'm happy to bisect and file. I just wanted an ACK that this is no bueno.
enough-analyst-54434
05/26/2022, 5:09 PMI generally have no clue what's deemed good vs bad! So I like to check.
h
hundreds-father-404
05/26/2022, 5:11 PMI expect it to be https://github.com/pantsbuild/pants/pull/15624. We have a lot of tests in
arg_splitter.py-he
enough-analyst-54434
05/26/2022, 5:14 PMhttps://github.com/pantsbuild/pants/issues/15660 - I'll add a bisect to the ticket.
š 1
h
hundreds-father-404
05/26/2022, 6:06 PMI finished the bug fix I was working on. Would it help for me to take this over? I almost certainly broke this code
e
enough-analyst-54434
05/26/2022, 6:09 PMI fleshed out the ticket and, yeah, there are 2 distinct bugs - 1 in @curved-television-6568's code and 1 in yours.
š 2
h
hundreds-father-404
05/26/2022, 6:09 PMThanks, sg
c
curved-television-6568
05/26/2022, 6:10 PM@hundreds-father-404 let me know if you want me to look at it at all š
h
hundreds-father-404
05/26/2022, 6:14 PMIf you have time to take a look at your PR, that would be great. I was going to start w/ mine
š 1
5 Views