https://pantsbuild.org/ logo
#general
Title
# general
d

dazzling-petabyte-91122

06/14/2022, 3:49 PM
quick question with Go. An upstream package is using embed, how do we handle that? I understand adding the resource targets for the app you’re creating, but what about upstream packages that also embed?
1
Getting this from the upstream package
Copy code
./gopath/pkg/mod/github.com/their-package/file.go: invalid go:embed: build system did not supply embed configuration
this issue https://github.com/pantsbuild/pants/issues/13193 references the third party packages but not sure if they’re actually supported?
sorry, bumping to see if anyone knows
w

witty-crayon-22786

06/14/2022, 6:37 PM
cc @fast-nail-55400
f

fast-nail-55400

06/14/2022, 7:38 PM
not currently supported because we didn’t write the code to map embed patterns in third-party code to the internal fields that handle embeds; we currently only map it for first-party code. that said, it isn’t all too hard to fix since our package analyzer is the same between first-party and third-party and the underlying build rules are agnostic to first-party/third-party code.
d

dazzling-petabyte-91122

06/14/2022, 7:48 PM
ah gotcha, ok thanks!
f

fast-nail-55400

06/14/2022, 7:48 PM
Could you open an issue for this?
d

dazzling-petabyte-91122

06/14/2022, 7:49 PM
sure
f

fast-nail-55400

06/14/2022, 9:28 PM
no need for an issue, that PR is the fix
PR landed on
main
. Would you need this back-ported to 2.12? Or will a release of 2.13.a0 in a week or so be fine?
d

dazzling-petabyte-91122

06/16/2022, 2:07 PM
no that’s fine
thanks!
👍 1
4 Views