quick question with Go. An upstream package is usi...
# generald
dazzling-petabyte-91122
06/14/2022, 3:49 PMquick question with Go. An upstream package is using embed, how do we handle that? I understand adding the resource targets for the app you’re creating, but what about upstream packages that also embed?
✅ 1
dazzling-petabyte-91122
06/14/2022, 4:09 PMGetting this from the upstream package
Copy code
./gopath/pkg/mod/github.com/their-package/file.go: invalid go:embed: build system did not supply embed configurationdazzling-petabyte-91122
06/14/2022, 6:27 PMthis issue https://github.com/pantsbuild/pants/issues/13193 references the third party packages but not sure if they’re actually supported?
dazzling-petabyte-91122
06/14/2022, 6:30 PMsorry, bumping to see if anyone knows
w
witty-crayon-22786
06/14/2022, 6:37 PMcc @fast-nail-55400
f
fast-nail-55400
06/14/2022, 7:38 PMnot currently supported because we didn’t write the code to map embed patterns in third-party code to the internal fields that handle embeds; we currently only map it for first-party code. that said, it isn’t all too hard to fix since our package analyzer is the same between first-party and third-party and the underlying build rules are agnostic to first-party/third-party code.
d
dazzling-petabyte-91122
06/14/2022, 7:48 PMah gotcha, ok thanks!
f
fast-nail-55400
06/14/2022, 7:48 PMCould you open an issue for this?
d
dazzling-petabyte-91122
06/14/2022, 7:49 PMsure
f
fast-nail-55400
06/14/2022, 9:28 PMfast-nail-55400
06/14/2022, 9:58 PMno need for an issue, that PR is the fix
fast-nail-55400
06/15/2022, 5:06 PMPR landed on
maind
dazzling-petabyte-91122
06/16/2022, 2:07 PMno that’s fine
dazzling-petabyte-91122
06/16/2022, 2:07 PMthanks!
👍 1
4 Views