Any thoughts on using a different docker repositor...
# generalb
bitter-ability-32190
06/20/2022, 9:09 PMAny thoughts on using a different docker repository for a given registry? E.g. for registry A use
fooibm-foobitter-ability-32190
06/20/2022, 9:10 PMbuild_args.ARG_NAMEc
curved-television-6568
06/20/2022, 9:24 PMLemme know if that doesn't work out. ;)
b
bitter-ability-32190
06/20/2022, 9:25 PMI dont think so
bitter-ability-32190
06/20/2022, 9:26 PMBecause AFAICT I can't make the name based on registry.
bitter-ability-32190
06/20/2022, 9:26 PMAnd so even if I could hack it, I'd need 2 publish commands
bitter-ability-32190
06/20/2022, 9:36 PMIs this pluggable? I'm down for more in repo plugins
c
curved-television-6568
06/21/2022, 5:28 AMNot pluggable.. yet. We could add that.
curved-television-6568
06/21/2022, 5:29 AMOr just fix the configurability for this case.. ;)
curved-television-6568
06/21/2022, 5:50 AMThere are per registry extra image tags. Could easily add per registry repository setting in there.
b
bitter-ability-32190
06/21/2022, 10:21 AMLet's do that. We're tagging on the CLI now so not blocked, but eventually I just want one command
bitter-ability-32190
06/21/2022, 12:39 PMI'm not sure how the design would look to be dlexible. I think ideally we allow a mapping of registry to additional context key/value pairs?
Then I can interpolate:
repository="{registry.PREFIX}{name}"c
curved-television-6568
06/21/2022, 5:20 PMSorry, my Mac is so broken since yesterday. I have a fix, just waiting to get it committed and pushed.
b
bitter-ability-32190
06/21/2022, 5:21 PMTake your time, lol We're a ways a way from upgrading anywho
c
curved-television-6568
06/21/2022, 5:22 PMI’ve been forced to use MS Defender, and it’s service has broken down and making my I/O supere sluggish and something eats my disk at a rate of Gb/minutes…
b
bitter-ability-32190
06/21/2022, 5:23 PMOh yeah, I remember all sorts of nightmares about antivirus at my last job
c
curved-television-6568
06/21/2022, 5:23 PMI still have 17% free disk left… so I think I hav time to push this before calling it the night. company support tells me they have a fix for me tomorrow…
b
bitter-ability-32190
06/21/2022, 5:23 PMWell dont try too hard 😛
c
curved-television-6568
06/21/2022, 5:24 PMhehe, oh yes!
curved-television-6568
06/21/2022, 5:24 PMjust running
./pants versioncurved-television-6568
06/21/2022, 5:39 PM@bitter-ability-32190 https://github.com/pantsbuild/pants/pull/15884 😉
curved-television-6568
06/21/2022, 5:40 PMNow you can have a registry repository setting like
"ibm-{target_repository}"curved-television-6568
06/21/2022, 5:41 PMtake a close look at the test case for image_ref formatting… 🙂
b
bitter-ability-32190
06/21/2022, 5:43 PMYup! Makes sense to me! I'll let @hundreds-father-404 review the contents of the change when they are back, but seems like it'd work flawlessly ❤️
👀 1
👍 1