mysterious-waiter-14207
07/09/2022, 7:39 AMClasspathEntry
is third party or first? I thought about adding a third_party
flag to ClasspathEntry
but it seems that a ClasspathEntry
can actually hold both first party and third party jars.
One alternative is to use some kind of regex to recognize coursier jars, but I'm not a big fan of it.
Few reasons for the plugin:
1. Merging all jars can take time
2. we want reproducible jars (no timestamps or metadata), coursier is already reproducible, so we only need to strip first party jars.
3. From our experience, merging jars (fat jar) can actually override resources in un-determinstic way.
4. We would later pack everything with Kaniko and only push the image to registry if digest is different.happy-kitchen-89482
07/11/2022, 2:35 AMancient-vegetable-10556
07/11/2022, 3:06 PMawait Get(Classpath, …)
). I think the best way to fix it would be to add a flag on ClasspathEntry
that indicates whether each entry came from a compile process or from Coursier.
At that point, ClasspathEntry
should do the right thing — .args()
already only provides arguments for the entry’s owned files, not the dependencies.mysterious-waiter-14207
07/11/2022, 3:28 PMisThirdParty
?ancient-vegetable-10556
07/11/2022, 3:31 PMmysterious-waiter-14207
07/11/2022, 3:42 PMclass ClasspathEntryType(Enum):
COMPILED = auto()
THIRD_PARTY = auto()
ancient-vegetable-10556
07/11/2022, 3:52 PMhappy-kitchen-89482
07/11/2022, 3:55 PMmysterious-waiter-14207
07/11/2022, 3:55 PMargs
and digest
methods to take a filter by the type? None is the default would not filter?ancient-vegetable-10556
07/11/2022, 3:57 PMfilter
method to Classpath
mysterious-waiter-14207
07/11/2022, 4:00 PMancient-vegetable-10556
07/11/2022, 4:01 PMpackage_deploy_jar
is 98% of the way to doing what you wantmysterious-waiter-14207
07/11/2022, 4:24 PMancient-vegetable-10556
07/11/2022, 4:24 PMmysterious-waiter-14207
07/11/2022, 4:25 PMancient-vegetable-10556
07/11/2022, 4:45 PMmysterious-waiter-14207
07/11/2022, 4:46 PMancient-vegetable-10556
07/11/2022, 4:47 PMmysterious-waiter-14207
07/11/2022, 4:57 PMancient-vegetable-10556
07/11/2022, 4:57 PMmysterious-waiter-14207
07/11/2022, 4:58 PM