open question about what to do when multiple linters sometimes need to make sequential changes. e.g. we have

def foo(arg: Union[str, list]):

formatting the file with our linters will allow all of them to pass except

pyupgrade

, which changes the line to

def foo(arg: str | list):

unfortunately, we still need to run our formatters once more, since now we’ve got an unused

from typing import Union

at the top of the file, which

autoflake

complains about. is there a better flow here that doesn’t require running our formatters twice or more times in a row? can we optimize this somehow so that some linters always run before other linters, so that in most cases they’d fix both issues in a single pass?

IIRC the order they are listed in

pants.toml

is the order they run in

fmt

do you know if anyone has looked into the optimal order to run formatters to reduce the likelihood of needing to do a rerun?

Relevant part of the docs: https://www.pantsbuild.org/docs/python-linters-and-formatters#order-of-backend_packages-matters-for-fmt Also below it: https://www.pantsbuild.org/docs/python-linters-and-formatters#black-and-isort-can-work-together

FWIW We're looking into making a dedicated

fix

goal for non-style changes. In this case you'd run

fix

before

fmt

nice, so i think tools which would go under

fix

should be run first, followed by

fmt

. i’m thinking a good order would be

pyupgrade
autoflake
docformatter
isort
black

There is probably a single fixed order that will work in practice, but in theory, we'd need to run tools repeatedly until the result converges, as nothing guarantees that a single fixed order exists