Could somebody point me the guide for migration pants plugin Pants #general

Could somebody point me the guide for migration pa...

rhythmic-morning-87313

07/25/2022, 4:42 AM

Could somebody point me the guide for migration pants plugins from 2.12.0 to 2.13.0rc0? I'm now trying to upgrade pants, and seeing errors related to rule graphs.

✅ 1

rhythmic-morning-87313

07/25/2022, 4:42 AM

Copy code

13:38:22.35 [ERROR] Encountered 16 rule graph errors:
  No installed rules return the type InjectPexBinaryEntryPointDependency, and it was not provided by potential callers of @rule(pants.backend.python.target_types_rules:207:inject_pex_binary_entry_point_dependency(InjectPexBinaryEntryPointDependency, PythonInferSubsystem, PythonSetup) -> InjectedDependencies, gets=[Get(WrappedTarget, WrappedTargetRequest), Get(ExplicitlyProvidedDependencies, DependenciesRequest), Get(ResolvedPexEntryPoint, ResolvePexEntryPointRequest), Get(PythonModuleOwners, PythonModuleOwnersRequest)]).
    If that type should be computed by a rule, ensure that that rule is installed.
    If it should be provided by a caller, ensure that it is included in any relevant Query or Get.
  No installed rules return the type InjectPythonDistributionDependencies, and it was not provided by potential callers of @rule(pants.backend.python.target_types_rules:420:inject_python_distribution_dependencies(InjectPythonDistributionDependencies, PythonInferSubsystem) -> InjectedDependencies, gets=[Get(WrappedTarget, WrappedTargetRequest), Get(ExplicitlyProvidedDependencies, DependenciesRequest), Get(ResolvedPythonDistributionEntryPoints, ResolvePythonDistributionEntryPointsRequest), Get(PythonModuleOwners, PythonModuleOwnersRequest)]).
    If that type should be computed by a rule, ensure that that rule is installed.
    If it should be provided by a caller, ensure that it is included in any relevant Query or Get.
  No installed rules return the type WrappedTargetRequest, and it was not provided by potential callers of @rule(pants.engine.internals.graph:330:resolve_target(WrappedTargetRequest, TargetTypesToGenerateTargetsRequests) -> WrappedTarget, gets=[Get(_TargetParametrizations, _TargetParametrizationsRequest)]).
    If that type should be computed by a rule, ensure that that rule is installed.
    If it should be provided by a caller, ensure that it is included in any relevant Query or Get.
  No source of dependency Get(ExplicitlyProvidedDependencies, DependenciesRequest) for @rule(pants.backend.python.target_types_rules:207:inject_pex_binary_entry_point_dependency(InjectPexBinaryEntryPointDependency, PythonInferSubsystem, PythonSetup) -> InjectedDependencies, gets=[Get(WrappedTarget, WrappedTargetRequest), Get(ExplicitlyProvidedDependencies, DependenciesRequest), Get(ResolvedPexEntryPoint, ResolvePexEntryPointRequest), Get(PythonModuleOwners, PythonModuleOwnersRequest)]). All potential sources were eliminated: []
  No source of dependency Get(ExplicitlyProvidedDependencies, DependenciesRequest) for @rule(pants.backend.python.target_types_rules:420:inject_python_distribution_dependencies(InjectPythonDistributionDependencies, PythonInferSubsystem) -> InjectedDependencies, gets=[Get(WrappedTarget, WrappedTargetRequest), Get(ExplicitlyProvidedDependencies, DependenciesRequest), Get(ResolvedPythonDistributionEntryPoints, ResolvePythonDistributionEntryPointsRequest), Get(PythonModuleOwners, PythonModuleOwnersRequest)]). All potential sources were eliminated: []
  No source of dependency Get(PythonModuleOwners, PythonModuleOwnersRequest) for @rule(pants.backend.python.target_types_rules:207:inject_pex_binary_entry_point_dependency(InjectPexBinaryEntryPointDependency, PythonInferSubsystem, PythonSetup) -> InjectedDependencies, gets=[Get(WrappedTarget, WrappedTargetRequest), Get(ExplicitlyProvidedDependencies, DependenciesRequest), Get(ResolvedPexEntryPoint, ResolvePexEntryPointRequest), Get(PythonModuleOwners, PythonModuleOwnersRequest)]). All potential sources were eliminated: []
  No source of dependency Get(PythonModuleOwners, PythonModuleOwnersRequest) for @rule(pants.backend.python.target_types_rules:420:inject_python_distribution_dependencies(InjectPythonDistributionDependencies, PythonInferSubsystem) -> InjectedDependencies, gets=[Get(WrappedTarget, WrappedTargetRequest), Get(ExplicitlyProvidedDependencies, DependenciesRequest), Get(ResolvedPythonDistributionEntryPoints, ResolvePythonDistributionEntryPointsRequest), Get(PythonModuleOwners, PythonModuleOwnersRequest)]). All potential sources were eliminated: []
  No source of dependency Get(ResolvedPexEntryPoint, ResolvePexEntryPointRequest) for @rule(pants.backend.python.target_types_rules:207:inject_pex_binary_entry_point_dependency(InjectPexBinaryEntryPointDependency, PythonInferSubsystem, PythonSetup) -> InjectedDependencies, gets=[Get(WrappedTarget, WrappedTargetRequest), Get(ExplicitlyProvidedDependencies, DependenciesRequest), Get(ResolvedPexEntryPoint, ResolvePexEntryPointRequest), Get(PythonModuleOwners, PythonModuleOwnersRequest)]). All potential sources were eliminated: []
  No source of dependency Get(ResolvedPythonDistributionEntryPoints, ResolvePythonDistributionEntryPointsRequest) for @rule(pants.backend.python.target_types_rules:420:inject_python_distribution_dependencies(InjectPythonDistributionDependencies, PythonInferSubsystem) -> InjectedDependencies, gets=[Get(WrappedTarget, WrappedTargetRequest), Get(ExplicitlyProvidedDependencies, DependenciesRequest), Get(ResolvedPythonDistributionEntryPoints, ResolvePythonDistributionEntryPointsRequest), Get(PythonModuleOwners, PythonModuleOwnersRequest)]). All potential sources were eliminated: []
  No source of dependency Get(WrappedTarget, WrappedTargetRequest) for @rule(pants.backend.python.target_types_rules:207:inject_pex_binary_entry_point_dependency(InjectPexBinaryEntryPointDependency, PythonInferSubsystem, PythonSetup) -> InjectedDependencies, gets=[Get(WrappedTarget, WrappedTargetRequest), Get(ExplicitlyProvidedDependencies, DependenciesRequest), Get(ResolvedPexEntryPoint, ResolvePexEntryPointRequest), Get(PythonModuleOwners, PythonModuleOwnersRequest)]). All potential sources were eliminated: []
  No source of dependency Get(WrappedTarget, WrappedTargetRequest) for @rule(pants.backend.python.target_types_rules:420:inject_python_distribution_dependencies(InjectPythonDistributionDependencies, PythonInferSubsystem) -> InjectedDependencies, gets=[Get(WrappedTarget, WrappedTargetRequest), Get(ExplicitlyProvidedDependencies, DependenciesRequest), Get(ResolvedPythonDistributionEntryPoints, ResolvePythonDistributionEntryPointsRequest), Get(PythonModuleOwners, PythonModuleOwnersRequest)]). All potential sources were eliminated: []
  No source of dependency Get(_TargetParametrizations, _TargetParametrizationsRequest) for @rule(pants.engine.internals.graph:330:resolve_target(WrappedTargetRequest, TargetTypesToGenerateTargetsRequests) -> WrappedTarget, gets=[Get(_TargetParametrizations, _TargetParametrizationsRequest)]). All potential sources were eliminated: []
  No source of dependency PythonInferSubsystem for @rule(pants.backend.python.target_types_rules:207:inject_pex_binary_entry_point_dependency(InjectPexBinaryEntryPointDependency, PythonInferSubsystem, PythonSetup) -> InjectedDependencies, gets=[Get(WrappedTarget, WrappedTargetRequest), Get(ExplicitlyProvidedDependencies, DependenciesRequest), Get(ResolvedPexEntryPoint, ResolvePexEntryPointRequest), Get(PythonModuleOwners, PythonModuleOwnersRequest)]). All potential sources were eliminated: []
  No source of dependency PythonInferSubsystem for @rule(pants.backend.python.target_types_rules:420:inject_python_distribution_dependencies(InjectPythonDistributionDependencies, PythonInferSubsystem) -> InjectedDependencies, gets=[Get(WrappedTarget, WrappedTargetRequest), Get(ExplicitlyProvidedDependencies, DependenciesRequest), Get(ResolvedPythonDistributionEntryPoints, ResolvePythonDistributionEntryPointsRequest), Get(PythonModuleOwners, PythonModuleOwnersRequest)]). All potential sources were eliminated: []
  No source of dependency PythonSetup for @rule(pants.backend.python.target_types_rules:207:inject_pex_binary_entry_point_dependency(InjectPexBinaryEntryPointDependency, PythonInferSubsystem, PythonSetup) -> InjectedDependencies, gets=[Get(WrappedTarget, WrappedTargetRequest), Get(ExplicitlyProvidedDependencies, DependenciesRequest), Get(ResolvedPexEntryPoint, ResolvePexEntryPointRequest), Get(PythonModuleOwners, PythonModuleOwnersRequest)]). All potential sources were eliminated: []
  No source of dependency TargetTypesToGenerateTargetsRequests for @rule(pants.engine.internals.graph:330:resolve_target(WrappedTargetRequest, TargetTypesToGenerateTargetsRequests) -> WrappedTarget, gets=[Get(_TargetParametrizations, _TargetParametrizationsRequest)]). All potential sources were eliminated: []

rhythmic-morning-87313

07/25/2022, 4:45 AM

I think the source of error is https://github.com/lablup/backend.ai/blob/main/tools/pants-plugins/platform_resources/register.py which is written with the help of @curved-television-6568...

curved-television-6568

07/25/2022, 5:48 AM

I think tnis may be the relevant change: https://github.com/pantsbuild/pants/pull/16107/files

👀 2

curved-television-6568

07/25/2022, 5:49 AM

Josh has been kind enough to include the docs update in the same PR.

rhythmic-morning-87313

07/26/2022, 7:11 AM

Thanks for the pointer! I'll look into.

rhythmic-morning-87313

07/26/2022, 9:28 AM

https://github.com/lablup/backend.ai/pull/589/commits/599a96b5d84d404644c5608fef6ce3f4ad59fa6d

rhythmic-morning-87313

07/26/2022, 9:29 AM

It no longer generates the rule graph errors, but it seems that my rule function is not executed at all..

rhythmic-morning-87313

07/27/2022, 2:44 AM

Hmm... I need some help on this plugin API migration (inject -> infer dependencies). Referring pantsbuild/pants#16107, the API change semes to be almost straight-forward, but I get lost because my rule function is not entered at all, so it is impossible to debug the changed logic.

bitter-ability-32190

07/27/2022, 7:51 AM

Can you give code snippets of your code before and after?

rhythmic-morning-87313

07/27/2022, 12:54 PM

@bitter-ability-32190 https://github.com/lablup/backend.ai/pull/589/commits/599a96b5d84d404644c5608fef6ce3f4ad59fa6d Here is the diff.

rhythmic-morning-87313

07/27/2022, 12:55 PM

what i'm observing is that

infer_platform_specific_dependencies()

function is not entered at all

bitter-ability-32190

07/27/2022, 1:50 PM

Are you sure your targets have both of the

required_fields

on them?

bitter-ability-32190

07/27/2022, 1:51 PM

It looks like it, if you're expecting it to work on

platform_resources

target 🤔

bitter-ability-32190

07/27/2022, 1:52 PM

Oh duh, lol. This change is in Pants 2.14 😂 https://github.com/pantsbuild/pants/pull/16107

The pull request first appeared in release_2.14.0.dev3

bitter-ability-32190

07/27/2022, 1:53 PM

Also under 2.14: https://github.com/pantsbuild/pants/blob/main/docs/markdown/Writing%20Plugins/common-plugin-tasks/plugin-upgrade-guide.md

rhythmic-morning-87313

07/28/2022, 1:04 PM

Ah, then how could I keep the prior version of my plugin compatible with 2.13? It still had a rule graph error as illustrated in the first message of this thread.

bitter-ability-32190

07/28/2022, 1:31 PM

There was a change to start using

WrappedTargetRequest

. That might've gone in 2.13 I think.

✅ 1

rhythmic-morning-87313

07/29/2022, 5:37 AM

https://github.com/lablup/backend.ai/pull/589/commits/5904e8706ac6c8b4d998c6a83917642420277538

rhythmic-morning-87313

07/29/2022, 5:37 AM

Now it works!

bitter-ability-32190

07/29/2022, 10:13 AM

awesome!

3 Views

Open in Slack

Previous Next