Is Pants able to infer dependancies between python test file

Question

Is Pants able to infer dependancies between python test files I have the structure like this gt src gt | python gt | package gt tests gt | python gt | package gt test 1 py gt test 2 py gt BUILD With a import in test 2 py like `from test 1 import function` However the test fails this import unless I explicitly provide python tests the source for `tests python package` gt python tests name= tests sources= tests python package Strangely while the above works it gives a Unmatched glob warning WARN Unmatched glob from tests python package tests s `sources` field tests python package tests python package

refined-addition-53644 · Answer

I think you need to define a `python test utils` and then make that as dependency

refined-addition-53644 · Answer

But yeah you still need explicit dependency it seems

cool-yacht-37128 · Answer

Thanks < refined addition 53644> An explicit dependancy on `python tests` back to itself `tests python package tests` did the trick Imports now work and no more warnings looks more like it would be more appropriate for test utility files such as stub files pyi and conftest py than actual test files

bitter-ability-32190 · Answer

wave Howdy OK a few things here sweat smile The `sources` field defines which files the generator target should use for generating targets It s also relative to the build dir So `sources= tests python package ` is saying there is one Python file named `tests python package` Then it warns because there is no file at that path Usually you don t need to change it as the default <https www pantsbuild org docs reference python tests codesourcescode> is usually correct

bitter-ability-32190 · Answer

According to the code I think Pants should be able to infer a dependency from one test to another But I also wanna say I ve seen similar behavior thinking face

bitter-ability-32190 · Answer

Lastly instead of adding a dependency from the tests generator to itself what you re doing is making every test file depend on every other test file which loses you fine grained invalidation and some perf you should use the `overrides` field to augment the dependencies of the single test file See <https www pantsbuild org docs reference python tests codeoverridescode>

happy-kitchen-89482 · Answer

Yeah I think Pants should be able to infer this dep so I am curious why it isn t but importing from another test is not a common pattern Is `function` an actual test function or a helper function

cool-yacht-37128 · Answer

It s a helper function I ve got another problem that might be related The code being tested is in a regular package structure has a init py The test code is just a bunch of modules If I make it a regular package by dropping in a init py into the directory it breaks the imports of actual code gt src gt | python gt | package gt | file 3 py gt init py gt tests gt | python gt | package gt test 1 py gt test 2 py gt BUILD test 1 py contains a wrapper around a function imported `from package file 3` in test 2 py I m trying to import that wrapper

cool-yacht-37128 · Answer

Now I think this is expected right since the package name for both the tests and the code will become `package` Should the tests python package directory name be changed

happy-kitchen-89482 · Answer

So generally we d recommend breaking a reusable helper function out into its own file which is owned by a `python test utils` target rather than have it be owned by a `python tests` since you re not using it as a test itself

happy-kitchen-89482 · Answer

Yeah you ve introduced a namespace package so the two ` init py`s have to account for that This isn t a Pants thing but a Python thing google python namespace package for details

happy-kitchen-89482 · Answer

It s common to name `package` something like `package tests` to avoid this problem since introducing a namespace package has its own complications and isn t worth doing just for tests I think

cool-yacht-37128 · Answer

I thought that might be the case thanks for confirming