Hey all. I’m seeing a strange issue in the Python monorepo I’m working in. We have several formatters setup (autoflake, black, and isort) and I’ve run them over the whole repository with

./pants fmt ::

. After this,

./pants lint ::

shows the linters are satisfied with the work they’ve done. However, if I then run

./pants lint subdirectory::

some of the linters complain that they would make changes (

isort

in particular). Any idea what’s going on here?

./pants tailor

succeeds without issue so the BUILD files look to be in order. ’m seeing a strange issue in the Python monorepo I’m working in. If I run

I think you're seeing an

isort

quirk. See https://www.pantsbuild.org/docs/python-linters-and-formatters#isort-possible-issues-with-its-import-classifier-algorithm

Ahh that makes sense. Because the changes

isort

tries to make in those subdirectories effectively reverts some of the changes it makes when running over the whole repo.

https://github.com/pantsbuild/pants/issues/15069 is relevant here

Yeah, this is an unfortunate "feature" of isort, I think the most robust workaround is to set the firstparty package explicitly in isort config.

Thanks! I got it sorted out after some reading and tinkering. For anybody else that runs into this, you’ll need to list your first-party imports in

known_first_party

in your isort config. Here is an example:

known_first_party = module_one,module_two,module_three,other_module