I'm trying

./pants tailor --changed-since=HEAD

as a pre-commit check, and it's adding things for unstaged files... is there a way to spell the index in a

--changed-diffspec=

so that this doesn't happen?

Here's the relevant code: https://github.com/pantsbuild/pants/blob/8c910d1d7c52a71d09b2e9265ef9aeeec7464443/src/python/pants/vcs/changed.py#L115-L129 https://github.com/pantsbuild/pants/blob/8c910d1d7c52a71d09b2e9265ef9aeeec7464443/src/python/pants/vcs/git.py#L72-L113 Maybe we would want to make this more nuanced? E.g. add an option whether staged files should be considered?

I mean.. yeah that's what i'm going for... I want be able to say the equivalent of

./pants --changed-diffspec=HEAD...<staged> tailor

I don't know if there's a way to express '<staged>' in spelling revisions though

One option is to try something like

./pants --spec-files=<(git diff-tree --cached --name-only --no-commit-id HEAD) list

. Although you may hit https://github.com/pantsbuild/pants/issues/5385 on bash

I tried that... it doesn't work for tailor specifically because pants wont

list

things it hasn't been told to pay attention to yet

what Pants version is this? In Pants 2.13,

tailor

learned how to work on file arguments regardless of targets existing or not 🙂

2.13rc0

hm, I'm not following then why this would be relevant?

it doesn't work for tailor specifically because pants wont list things it hasn't been told to pay attention to yet

In the code snippet, use

tailor

rather than

list

. That should feed Pants a bunch of (possibly unowned) files, and it should know what to do

oh, have to change the deprecated directory semantics thing