https://pantsbuild.org/ logo
#general
Title
# general
r

refined-addition-53644

08/16/2022, 7:57 PM
Hi, It’s not very clear to me how the
complete_platforms
option should look like in
pex_binary
The docs for pex says
The complete platform can be either a path to a file containing JSON data or else a JSON object literal.
On the other hand, docs for pex_binary says
Complete platforms should be addresses of
file
targets that point to files that contain complete platform JSON as described by Pex
I think an example would be helpful like we have for platforms
h

hundreds-father-404

08/16/2022, 8:01 PM
Even better imo would be improving the API: https://github.com/pantsbuild/pants/issues/15234 Help absolutely appreciated if anyone is interested
👍 1
r

refined-addition-53644

08/16/2022, 8:04 PM
I would be interested in making the required change. Although from the ticket it’s not very clear to me what needs to be done.
h

hundreds-father-404

08/16/2022, 8:04 PM
awesome! I will add some thoughts
❤️ 1
opinions on whether we should support this?
or else a JSON object literal.
It's easier if we only do file paths
r

refined-addition-53644

08/16/2022, 8:09 PM
I think it's alright as long as we make it clear in the docs.
👍 1
h

hundreds-father-404

08/16/2022, 11:34 PM
commented 🙂