I am trying to build a Python distribution wheel using the `

Question

I am trying to build a Python distribution wheel using the `python distribution` target using a handwritten `setup py` file The docs say that gt If you use a handwritten setup py Pants will bundle whatever the script tells it to Running `python3 setup py bdist wheel` produces a wheel with expected contents whereas ` pants package say hello` produces a wheel with `dist info` metadata only Have I misunderstood how Pants runs the existing `setup py`

fresh-cat-90827 · Answer

Using <https github com pantsbuild example python> root `BUILD` file ```python sources name= setup py sources= setup py python distribution name= say hello dependencies= setup py provides=python artifact name= say hello generate setup=False sdist=False ```

enough-analyst-54434 · Answer

How does that target graph know what the source file dependencies are I think you re missing dependencies for say hello

enough-analyst-54434 · Answer

It only knows about setup py and no other sources from what you have written down

fresh-cat-90827 · Answer

That s my question I thought that because there is `setup py` Pants will run the `setup ` function which does find the packages etc

enough-analyst-54434 · Answer

You are probably forgetting Pants copies all needed files off to a tmp sandbox before doing anything

enough-analyst-54434 · Answer

When you run setup py in tree the files are just laying there

enough-analyst-54434 · Answer

Pants though needs to know the full list to copy them to the sandbox

enough-analyst-54434 · Answer

This is true of all pants actions

enough-analyst-54434 · Answer

SO you re right Pants runs the setup function in the sandbox

enough-analyst-54434 · Answer

And the sandbox has no other files besides setup py right now

fresh-cat-90827 · Answer

I see this makes sense So if I want to piggy back on `setup py` functionality to find all the packages etc then I have to make sure I get the whole tree with me as a dependency of `python distribution`

enough-analyst-54434 · Answer

So you need ```dependencies= setup py target containing actual code ```

enough-analyst-54434 · Answer

Yes

enough-analyst-54434 · Answer

That s exactly it If you hand manage setup py you have to hand manage everything else too

fresh-cat-90827 · Answer

gotcha Got it working with ```python distribution name= say hello dependencies= setup py MANIFEST helloworld lib helloworld greet lib helloworld greet translations helloworld translator lib ``` I wonder if there s a shortcut to refer to all targets located under a directory I can t use `helloworld ` gt UnsupportedWildcard The address `helloworld ` included a wildcard ` ` which is not supported confused

enough-analyst-54434 · Answer

That was pretty intentionally never supported since it generally only leads to badness

happy-kitchen-89482 · Answer

Very often you only need to depend on the entry point because that presumably already depends on everything it needs

enough-analyst-54434 · Answer

Good and supported on CLI generally bad for BUILD just like import is generally bad for code

fresh-cat-90827 · Answer

oh yes thanks Benjy ```python distribution name= say hello dependencies= setup py MANIFEST helloworld pex binary ``` is enough indeed Reading the docs I thought using `pex binary` won t be enough because its transitive dependencies wouldn t be picked up gt Naively you might think that a python distribution publishes all the code of all the python source targets it transitively depends on But that could easily lead to trouble if you have multiple distributions that share common dependencies You typically don t want the same code published in multiple distributions as this can lead to all sorts of runtime import issues

happy-kitchen-89482 · Answer

With a generated setup py Pants partitions your code across the possible dists so that you don t have that duplication With your own setup py you have to do that yourself or suffer the duplication consequences