I'm so giddy! Only two ONE prep PR left before I c...
# general
p
I'm so giddy! Only two ONE prep PR left before I can start introducing pants to the StackStorm repo! https://github.com/StackStorm/st2/pulls?q=is%3Apr+is%3Aopen+label%3Apantsbuild
💯 2
👏 2
🔥 6
🎆 2
🚀 2
b
That has gotta be really freaking exciting after having worked so hard for so long on meticulously proving your case. Congrats, and can't wait to celebrate with you when the countdown goes to zero!
💯 2
p
The oldest commit on my pants branch is dated 2021-03-27 150553 😅
1
I started with v2.3.0
b
The finish line is so tantalizingly close...
p
https://github.com/StackStorm/st2/pull/5713 I didn't wait for the last PR to get the final review... 😄 I expect this process to take quite awhile because I want to get maintainers familiar with it as I go.
❤️ 1
h
Yay! and I'm glad you're using 2.13. I think you want to set
use_deprecated_directory_cli_args_semantics
and
use_deprecated_pex_binary_run_semantics
to False though in GLOBAL; they become the default in 2.14
p
I would use 2.14 for
__defaults__
, but that's probably a bit too raw at this point. I want to minimize how much I introduce reviewers in each PR... There's a lot that needs to end up in pants.toml https://github.com/st2sandbox/st2/blob/pants/pants.toml Maybe, by the time I've got pants ready for use in the st2 repo, 2.14 will be available 😄
1