ancient-france-42909
08/19/2022, 6:04 PMhundreds-father-404
08/19/2022, 6:06 PMcurved-television-6568
08/19/2022, 6:32 PMcurved-television-6568
08/19/2022, 6:36 PMIs there a way to stop docker from pushing latest, without putting that into tags for each package?Currently there's no easy way to prohibit the push of a specific tag, only all tags per registry. If you describe what you want to achieve I may be able to provide a workable work around. Please feel free to submit a feature request on Github for this in the mean time.
ancient-france-42909
08/19/2022, 6:38 PM:pr-$PR_NUMBER
. My understanding is that if I do extra_tags = ["{build_args.IMAGE_TAG}"]
, that will push that and latest
?curved-television-6568
08/19/2022, 6:41 PMextra_tags
refers to, as there are only image_tags
on the docker_image
target and extra_image_tags
configuration for the docker
subsystem.ancient-france-42909
08/19/2022, 6:41 PMextra_image_tags
, yeah.curved-television-6568
08/19/2022, 6:41 PMcurved-television-6568
08/19/2022, 6:44 PMimage_tags
is ["latest"]
, so you'd want to either use a macro to provide your own default (maybe empty list), or (unattractive from your perspective, I realize) bleeding edge where there is a new feature to provide custom default field values using a new __defaults__
feature in the BUILD file.
As the extra_image_tags
adds to any tags provided on the docker_image
(including the default)ancient-france-42909
08/19/2022, 6:44 PMhundreds-father-404
08/19/2022, 6:47 PMhundreds-father-404
08/19/2022, 6:47 PMa0
, given our release cadenceancient-france-42909
08/19/2022, 6:48 PMcurved-television-6568
08/19/2022, 6:49 PM"extra_image_tags = ["!latest", ...]
and backport that to 2.13hundreds-father-404
08/19/2022, 6:49 PMand backport that to 2.13We're trying to get out the stable release by end of next week at the latest, so I'm gonna be a party pooper and discourage us from backporting new features. Only backport performance fixes and bug fixes
curved-television-6568
08/19/2022, 6:52 PMimage_tags
with an empty list seems to be what you want here, and to avoid having to do that for every target, using a macro is likely the best approach (granted, you'd have to change all docker_image
targets to your macro version, but from there it would be transparent going forward)ancient-france-42909
08/19/2022, 6:52 PMancient-france-42909
08/19/2022, 6:53 PMhundreds-father-404
08/19/2022, 6:53 PMancient-france-42909
08/19/2022, 6:55 PMancient-france-42909
08/19/2022, 6:55 PMancient-france-42909
08/19/2022, 6:55 PMhundreds-father-404
08/19/2022, 6:56 PMpython_test_utils
change, I know that was particularly painful đ It was a Gedanken bug with our modeling and we spent a lot of time trying to find a workaround. I really wish we got the modeling right in the beginningancient-france-42909
08/19/2022, 6:59 PM