What should be the value of `PEX ROOT` at the time of bootst

Question

What should be the value of `PEX ROOT` at the time of bootstrapping

witty-crayon-22786 · Answer

it shouldn t matter Pants filters ~all environment variables as it starts up

witty-crayon-22786 · Answer

the PEX ROOT is set for individual processes automatically as they run

bored-glass-58755 · Answer

I asked because I am getting a warning `Scrubbing PEX ROOT` in my CI This is not the case when I bootstrap on my local machine

witty-crayon-22786 · Answer

yea that s correct you should do not need to set PEX ROOT

witty-crayon-22786 · Answer

the warning is to point out that it will not be used

witty-crayon-22786 · Answer

Pants will locate the pex root under the named caches dir

bored-glass-58755 · Answer

Ok but it doesn t seem to be trying to locate under named caches dir because I have set it in my `pants toml` Also would you be able to explain the reason why I don t get this warning on my local machine but in CI

bored-glass-58755 · Answer

I get this warning regardless of whether or not I set `PEX ROOT` in my bootstrapping CI Furthermore I have set `named caches dir` in `pants toml` but it doesn t seem to be using that location as `PEX ROOT`

enough-analyst-54434 · Answer

< ancient rose 27306> the best help here would be remote eyes Is there any way you can share the portion of the CI logs frm start until this warning point with redactions path edits as needed for any sensitive info

bored-glass-58755 · Answer

Here are the redacted logs ```Bootstrapping Pants using venv bin python3 Creating the virtualenv PEX Downloading the Pex PEX SHA256 fingerprint of <https github com pantsbuild pex releases download v2 1 62 pex> verified Scrubbing PEX ROOT $BUILD ROOT $BUILD DIR tmp tmpakewj1fy unzipped pexes 70e3732fb536dad57e716bdab53bcec29ebaa5e4 bootstrap pex pex info py 384 PEXWarning PEX ROOT is configured as $HOME pex but that path is un writeable falling back to a temporary PEX ROOT of $BUILD DIR tmp tmprg6j0sk7 which will hurt performance performance format pex root=pex root tmp root=tmp root $BUILD ROOT $BUILD DIR tmp tmpakewj1fy installed wheels affd08bdf38c0eac7b9fd0ac2f464442e4147274 pex 2 1 62 py2 py3 none any whl pex variables py 577 PEXWarning PEX ROOT is configured as $HOME pex but that path is un writeable falling back to a temporary PEX ROOT of $BUILD ROOT $BUILD DIR tmp tmpg37ji46o which will hurt performance performance format pex root=pex root tmp root=tmp root $BUILD ROOT $BUILD DIR tmp tmpakewj1fy installed wheels affd08bdf38c0eac7b9fd0ac2f464442e4147274 pex 2 1 62 py2 py3 none any whl pex pex info py 384 PEXWarning PEX ROOT is configured as $HOME pex but that path is un writeable falling back to a temporary PEX ROOT of $BUILD ROOT $BUILD DIR tmp tmp15i5mqlb which will hurt performance performance format pex root=pex root tmp root=tmp root Installing pantsbuild pants==2 12 0 into a virtual environment at $WORKDIR bootstrap Linux x86 64 2 12 0 py37 Scrubbing PEX ROOT $BUILD ROOT $BUILD DIR tmp tmphphtbuvw unzipped pexes 01a7d467141015c7b3a0aee086ae57d13816e770 bootstrap pex pex info py 384 PEXWarning PEX ROOT is configured as $HOME pex but that path is un writeable falling back to a temporary PEX ROOT of $BUILD DIR tmp tmpyrjkfwyb which will hurt performance performance format pex root=pex root tmp root=tmp root New virtual environment successfully created at $WORKDIR bootstrap Linux x86 64 2 12 0 py37 17 44 18 81 INFO Initializing scheduler 17 44 19 07 INFO Scheduler initialized 2 12 0```

bored-glass-58755 · Answer

And after this bootstrap that seems to have completed successfully I am getting following error when running the command ` pants tailor check update build files check` in CI after bootstrap ```17 44 21 83 INFO Initializing scheduler 17 44 22 10 INFO Scheduler initialized 17 44 22 15 ERROR 1 Exception encountered Exception Failed to read link $WORKDIR bootstrap Linux x86 64 2 12 0 py37 Absolute symlink $WORKDIR bootstrap Linux x86 64 pants faI76R install error Bash exited with code 1 ```

enough-analyst-54434 · Answer

Ok as to the 1st warning that s on the tin `$HOME pex`is unwriteable So to get that warning to go away you ll need to run something like `PEX ROOT= writeable location pants version`as the 1st step That said the warning is ignorable so it s up to you

enough-analyst-54434 · Answer

As to the second issue what is $WORKDIR Is that the root of the code repo you re running Pants in

enough-analyst-54434 · Answer

If so it has to be any other directory not in the repo tree

bored-glass-58755 · Answer

Thanks for the help with `PEX ROOT` And yes the `$WORKDIR` is the root of the code repo

enough-analyst-54434 · Answer

Yeah that is a no go Pants needs to have its caches all not be in any repo that uses Pants this is a white lie but you really don t want to fight through this The idea is you setup Pants once globally and then various repos use it The `pants` script checked into each repo is just a thin shim

enough-analyst-54434 · Answer

So in CI you don t really get the benefit of a global Pants install you re install it every time but the do not house inside the repo itself still applies

bored-glass-58755 · Answer

Ok thanks That means I need to set `PANTS SETUP CACHE` to another directory which is not the root And thanks for clarifying the CI install thing as that would have been my follow up question slightly smiling face

enough-analyst-54434 · Answer

The easiest way to set all this is just export `XDG CACHE HOME`

enough-analyst-54434 · Answer

Every other global Pants cache default based off that

bored-glass-58755 · Answer

`PEX ROOT` also shouldn t be the repo root but can be same as `PANTS SETUP CACHE`

enough-analyst-54434 · Answer

It should be `$XDG CACHE HOME pex` probably for sanity sake

bored-glass-58755 · Answer

Ok will look into `XDG CACHE HOME`

bored-glass-58755 · Answer

Just in case if I am unable to export `XDG CACHE HOME` its ok if I use the same location for both `PEX ROOT` and `PANTS SETUP CACHE`

enough-analyst-54434 · Answer

For sanity sake you d want something like `PEX ROOT=$PANTS SETUP CACHE pex root` That said if your CI step can run ` pants` its almost inconceivable it can t run `PEX ROOT=foo XDG CACHE HOME=bar ANY ENV VAR I WANT=baz pants `

bored-glass-58755 · Answer

Ok so if I run `XDG CACHE HOME=some dir pants version` would it automatically take `some dir ` as `PANTS SETUP CACHE` and `some dir pex` as `PEX ROOT`

enough-analyst-54434 · Answer

No `PEX ROOT` does not resect the XDG freedesktop standard so you have to set it separately That said that only will squelch a warning that is immaterial in the 1 time bootstrap process Pants itself sets a `PEX ROOT` internally elsewhere under its own cache structure that is all covered by you exporting `XDG CACHE HOME`

enough-analyst-54434 · Answer

So only `XDG CACHE HOME` is required `PEX ROOT`is cosmetic and just used to build a venv 1 time to house the Pants binary itself

enough-analyst-54434 · Answer

This of course needs to be cleaned up Very confusing

bored-glass-58755 · Answer

So I tried setting up `XDG CACHE HOME` but it did not prevent the `Scrubbing PEX ROOT` warning ```echo $XDG CACHE HOME amp amp echo $PANTS SETUP CACHE amp amp echo $PEX ROOT amp amp pants version ========================== Starting Command Output =========================== $WORKDIR One directory up the repo root Also $XDG CACHE HOME $WORKDIR $WORKDIR pex One directory up the repo root pex Bootstrapping Pants using venv bin python3 Creating the virtualenv PEX Downloading the Pex PEX SHA256 fingerprint of <https github com pantsbuild pex releases download v2 1 62 pex> verified Scrubbing PEX ROOT $BUILD ROOT $BUILD DIR tmp tmpwfmzxkpt unzipped pexes 70e3732fb536dad57e716bdab53bcec29ebaa5e4 bootstrap pex pex info py 384 PEXWarning PEX ROOT is configured as $HOME pex but that path is un writeable falling back to a temporary PEX ROOT of $BUILD DIR tmp tmpiuaz7z 5 which will hurt performance performance format pex root=pex root tmp root=tmp root $BUILD ROOT $BUILD DIR tmp tmpwfmzxkpt installed wheels affd08bdf38c0eac7b9fd0ac2f464442e4147274 pex 2 1 62 py2 py3 none any whl pex variables py 577 PEXWarning PEX ROOT is configured as $HOME pex but that path is un writeable falling back to a temporary PEX ROOT of $BUILD ROOT $BUILD DIR tmp tmpxcr8mdzi which will hurt performance performance format pex root=pex root tmp root=tmp root $BUILD ROOT $BUILD DIR tmp tmpwfmzxkpt installed wheels affd08bdf38c0eac7b9fd0ac2f464442e4147274 pex 2 1 62 py2 py3 none any whl pex pex info py 384 PEXWarning PEX ROOT is configured as $HOME pex but that path is un writeable falling back to a temporary PEX ROOT of $BUILD ROOT $BUILD DIR tmp tmpr1dktv19 which will hurt performance performance format pex root=pex root tmp root=tmp root Installing pantsbuild pants==2 12 0 into a virtual environment at $WORKDIR bootstrap Linux x86 64 2 12 0 py37 Scrubbing PEX ROOT $BUILD ROOT $BUILD DIR tmp tmpevybnbwf unzipped pexes 01a7d467141015c7b3a0aee086ae57d13816e770 bootstrap pex pex info py 384 PEXWarning PEX ROOT is configured as u1 svcazagt pex but that path is un writeable falling back to a temporary PEX ROOT of $BUILD DIR tmp tmpv0nkm9mb which will hurt performance performance format pex root=pex root tmp root=tmp root New virtual environment successfully created at $WORKDIR bootstrap Linux x86 64 2 12 0 py37 22 13 32 67 INFO Initializing scheduler 22 13 32 98 INFO Scheduler initialized 2 12 0```

enough-analyst-54434 · Answer

Correct see <https pantsbuild slack com archives C046T6T9U p1661436170149839 thread ts=1661373158 171129 amp cid=C046T6T9U|https pantsbuild slack com archives C046T6T9U p1661436170149839 thread ts=1661373158 171129 amp cid=C046T6T9U>

enough-analyst-54434 · Answer

Oh looked at the output more You say you tried setting up `XDG CACHE HOME` but you actually did set both `XDG CACHE HOME` and `PEX ROOT` as evidenced by the echos Let me check Pex changelogs The Pex PEX used to bootstrap Pants is fairly old ~2 1 60 I think and Pex is now ~40 releases down the road and this seems to ring a bell

enough-analyst-54434 · Answer

Oh right see this line above the warning `Scrubbing PEX ROOT` that s done here <https github com pantsbuild setup blob eb887ad5fd80766214e8c38102a5bc92d1342beb pants L282 L295>

enough-analyst-54434 · Answer

So I think the path forward to get rid of the warning is probably to have Pex support XDG That would mean you only need to set `XDG CACHE HOME` and that env var would not get scrubbed cleaning up both messes and making the Pants Pex system well behaved as a free desktop app system Shorter term the `pants` script could be special cased to do something like ```$ cat test sh function scrub env vars Ensure the virtualenv PEX runs as shrink wrapped See <https github com pantsbuild setup issues 105> local r pex env vars= $ PEX local r scrub pex env vars= $ pex env vars PEX ROOT if n $ scrub pex env vars then echo gt amp 2 Scrubbing $ scrub pex env vars unset $ scrub pex env vars fi echo gt amp 2 Raw env env | grep PEX scrub env vars echo gt amp 2 Scrubbed env env | grep PEX $ PEX FOO=foo PEX ROOT=root PEX BAR=bar bash test sh Raw env PEX ROOT=root PEX FOO=foo PEX BAR=bar Scrubbing PEX BAR PEX FOO Scrubbed env PEX ROOT=root```

enough-analyst-54434 · Answer

< bored glass 58755> if that warning bothers you enough and you d like to contribute something like that fix I d be happy to review

bored-glass-58755 · Answer

Hi < enough analyst 54434> thanks a lot for your responses Yes I had seen pants script before reaching out and thought maybe there s a way to avoid that warning Lastly yes I d be happy to contribute to remove that warning I will make the change and test it in my CI first

enough-analyst-54434 · Answer

Great thank you

bored-glass-58755 · Answer

Ok so the `Scrubbing PEX ROOT` warning has disappeared after making changes to the script but it is still giving below warnings as before Moreover the Pants fails to bootstrap ```$XDG CACHE HOME pants named caches pex root installed wheels affd08bdf38c0eac7b9fd0ac2f464442e4147274 pex 2 1 62 py2 py3 none any whl pex pex info py 384 PEXWarning PEX ROOT is configured as $HOME pex but that path is un writeable falling back to a temporary PEX ROOT of $BUILD ROOT $BUILD DIR tmp tmp9f796zn1 which will hurt performance performance format pex root=pex root tmp root=tmp root $XDG CACHE HOME pants named caches pex root installed wheels affd08bdf38c0eac7b9fd0ac2f464442e4147274 pex 2 1 62 py2 py3 none any whl pex pex bootstrapper py 493 PEXWarning The venv for $XDG CACHE HOME pants named caches pex root pip pex c15b6e999f7b2b553c5ee23e542ae1e620d5dcf2 at $XDG CACHE HOME pants named caches pex root venvs e61f97e90815934b3b69dc4a58ecf7e05555084b 15d3ad9788dc0da4a814dd5bb1a36eed666cd279 has script shebangs of $XDG CACHE HOME pants named caches pex root venvs s 01aec573 venv bin python3 7 sE with 139 characters On some systems this may be too long and cause problems running the venv scripts You may be able adjust PEX ROOT from $XDG CACHE HOME pants named caches pex root to a shorter path as a work around pex root=pex info pex root Failed to spawn a job for DistributionTarget interpreter=PythonInterpreter usr local python 3 7 6 bin python3 7 PythonIdentity usr local python 3 7 6 bin python3 7 cp37 cp37m manylinux 2 17 x86 64 3 7 6 Errno 2 No such file or directory $XDG CACHE HOME pants named caches pex root venvs e61f97e90815934b3b69dc4a58ecf7e05555084b 15d3ad9788dc0da4a814dd5bb1a36eed666cd279 pex $XDG CACHE HOME pants named caches pex root venvs e61f97e90815934b3b69dc4a58ecf7e05555084b 15d3ad9788dc0da4a814dd5bb1a36eed666cd279 pex mv cannot stat $XDG CACHE HOME pants setup bootstrap Linux x86 64 pants R0iluW virtualenv pex No such file or directory Installing pantsbuild pants==2 12 0 into a virtual environment at $XDG CACHE HOME pants setup bootstrap Linux x86 64 2 12 0 py37 usr local bfm ext ado admin venv bin python3 can t open file $XDG CACHE HOME pants setup bootstrap Linux x86 64 virtualenv 20 4 7 virtualenv pex Errno 2 No such file or directory error Bash exited with code 1 Finishing Pants bootstrap step ``` I fail to understand why in the first line of logs above it says `PEXWarning PEX ROOT is configured as $HOME pex` I am looking at entire script now to try and remove these errors

enough-analyst-54434 · Answer

Yeah 1st stop is to print out the env vars post scrub but pre running pex to confirm Pex is seeing the PEX ROOT you expect

bored-glass-58755 · Answer

Yes will get back to you with my findings

bored-glass-58755 · Answer

It seems following line in function `bootstrap virtualenv` is resulting in error and therefore the subsequent move command is failing and therefore the bootstrap is failing ` $ python $ pex path r requirements txt c virtualenv o virtualenv pex` I am now looking at why preventing the `PEX ROOT` from being scrubbed is resulting in above command s failure During the execution of above command we get following warning even though `PEX ROOT` is not set to what the warning suggests `$XDG CACHE HOME pants named caches pex root installed wheels affd08bdf38c0eac7b9fd0ac2f464442e4147274 pex 2 1 62 py2 py3 none any whl pex pex info py 384 PEXWarning PEX ROOT is configured as $HOME pex but that path is un writeable falling back to a temporary PEX ROOT of local build tmp tmpktux9t7v which will hurt performance ` ` performance format pex root=pex root tmp root=tmp root `

enough-analyst-54434 · Answer

So you have added an echo post scrub but pre run and that echo proves PEX ROOT= what you want

bored-glass-58755 · Answer

It seems to me that `pex 2 1 62` is set to use `PEX ROOT` as `$HOME pex`

enough-analyst-54434 · Answer

That is the default for all Pex for all time yes

bored-glass-58755 · Answer

gt So you have added an echo post scrub but pre run and that echo proves PEX ROOT= what you want Yes

enough-analyst-54434 · Answer

Ok Have you tried bumping the Pex version then to latest + edit the sha

bored-glass-58755 · Answer

But then there must be a way to override the default

enough-analyst-54434 · Answer

There is PEX ROOT also has existed for all time

bored-glass-58755 · Answer

gt Ok Have you tried bumping the Pex version then to latest + edit the sha Let me try this now

enough-analyst-54434 · Answer

So this is a more subtle issue somewhere

enough-analyst-54434 · Answer

The version is 2 1 103 and the hash is 4d45336511484100ae4e2bab24542a8b86b12c8cb89230463593c60d08c4b8d3

bored-glass-58755 · Answer

We ll be in touch

bored-glass-58755 · Answer

gt Ok Have you tried bumping the Pex version then to latest + edit the sha So I bumped Pex version to `2 1 103` and the PEXWarning is no more the one which said that `PEX ROOT` is set as `$HOME pex` which was un writable The only warning that I get now is regarding the long `PEX ROOT` path which I don t think can be avoided unless I choose to use a shorter path for `XDG CACHE HOME` ```Bootstrapping Pants using venv bin python3 Creating the virtualenv PEX Downloading the Pex PEX SHA256 fingerprint of <https github com pantsbuild pex releases download v2 1 103 pex> verified $XDG CACHE HOME pants named caches pex root installed wheels 6a3c9545f9bc666f039874243789bf4ba5cc4fbde5a945eca40a651de360568b pex 2 1 103 py2 py3 none any whl pex pex bootstrapper py 557 PEXWarning The venv for XDG CACHE HOME pants named caches pex root pip pex d1893e3bec4d47905ad270be40669a781dc00206 at XDG CACHE HOME pants named caches pex root venvs 15158fe84406f2733a98f687f98d59238ad4210d 15d3ad9788dc0da4a814dd5bb1a36eed666cd279 has script shebangs of XDG CACHE HOME pants named caches pex root venvs s 883b36a3 venv bin python3 7 sE with 139 characters On some systems this may be too long and cause problems running the venv scripts You may be able adjust PEX ROOT from XDG CACHE HOME pants named caches pex root to a shorter path as a work around pex root=pex info pex root Installing pantsbuild pants==2 12 0 into a virtual environment at $XDG CACHE HOME pants setup bootstrap Linux x86 64 2 12 0 py37 New virtual environment successfully created at $XDG CACHE HOME pants setup bootstrap Linux x86 64 2 12 0 py37 01 34 33 57 INFO Initializing scheduler 01 34 33 85 INFO Scheduler initialized 2 12 0 Finishing Pants bootstrap step ``` I tried looking into sources of Pex versions `2 1 62` `2 1 79` `2 1 90` and `2 1 103` but couldn t find any difference between them that could point towards the reason for why the warning was generated Another question that I have is if it is possible at the time of Pants bootstrapping that Pants downloads a version other than what is mentioned in `pants` script I ask this because I have two bootstrapped Pants in my local machine s `$HOME cache pants` and neither of them has `2 1 62` version of Pex which was mentioned in the script I have `2 1 79` and `2 1 90` in both of those Pants setups Could it be because of pex downloads that happen at the time of using Pants as in running various goals like `package` `publish` etc

bored-glass-58755 · Answer

Apart from above I have below questions regarding `pants` script 1 In the function `bootstrap pex ` why do we create `$ PANTS BOOTSTRAP ` directory just after the message Downloading the Pex PEX I ask this because we anyways create `$ bootstrapped ` in the same function just after verifying the SHA256 2 Why do we create `$ PANTS BOOTSTRAP ` directory again in the function `bootstrap virtualenv ` just after after returning from the function `bootstrap pex ` which anyways created this directory

bored-glass-58755 · Answer

Lastly could you please guide me if there s a developer contributor setup that needs to be done or I can just create a branch and submit a PR with modified script Shall I also bump the version in the same PR

bored-glass-58755 · Answer

Hi I followed this to setup Pants for local development however the `pants` script in the root folder isn t the same as that gets downloaded with the command ` bin bash c $ curl fsSL ` Rather it seems to be the one that bootstrap Pants executing Rust compilation and all at the time of contributor setup Could you please advise me on how to proceed with fixing the script

enough-analyst-54434 · Answer

It was buried up here But the `pants` setup script used by all repos except the Pants repo itself is housed in on the `gh pages` branch a special branch that Github will serve up over plain https The best way to get setup for contributing to that repo is well this is the trick I use for any repo read the CI setup Whatever CI does you ll need to do The nice thing is this strategy works for any sane tested open source project So in that repo s case you need to be able to run `tox e format check lint typecheck` and `tox e test` You may or may not need the extra ` basetemp `args CI needs So 1st step install `tox` and next step ensure `tox e format check lint typecheck test` passes on a fresh clean `gh pages` branch

bored-glass-58755 · Answer

Thanks < enough analyst 54434> let me start with that

bored-glass-58755 · Answer

Ok so following commands ran successfully `tox e format run` `tox e format check` `tox e lint` `tox e typecheck` However `tox e test` finished with 6 passed and 12 failed

bored-glass-58755 · Answer

Got following for 10 out of 12 failed test cases ```E subprocess CalledProcessError Command pants version returned non zero exit status 1 miniconda3 envs pants setup dev lib python3 9 subprocess py 528 CalledProcessError``` I am using a conda environment with python 3 9 on a linux machine Is there anything that I am missing

enough-analyst-54434 · Answer

Ok then you probably need to work through that I m sorry to be terse but you gave me little to go on

enough-analyst-54434 · Answer

Ah yes So the tests test old Pants IIRC and some of the old Pants probably require old Pythons

enough-analyst-54434 · Answer

Just a sec

bored-glass-58755 · Answer

Pants 2 12 0 is bootstrapped for both python 3 7 and 3 9

bored-glass-58755 · Answer

I used python 3 9 because that s what ci yml suggested

enough-analyst-54434 · Answer

Yes it is but if you read the unit tests code you should see strings like 1 30 1

enough-analyst-54434 · Answer

CI has this trick <https github com pantsbuild setup blob gh pages github workflows ci yml L45>

enough-analyst-54434 · Answer

And that plays out like this <https github com pantsbuild setup runs 6712806317 check suite focus=true step 4 47> Expand the node and you see ``` Exposing opt hostedtoolcache Python 2 7 18 x64 bin Python 2 7 18 Exposing opt hostedtoolcache Python 3 10 4 x64 bin Python 3 10 4 Exposing opt hostedtoolcache Python 3 6 15 x64 bin Python 3 6 15 Exposing opt hostedtoolcache Python 3 7 13 x64 bin Python 3 7 13 Exposing opt hostedtoolcache Python 3 8 12 x64 bin Python 3 8 12 Exposing opt hostedtoolcache Python 3 9 13 x64 bin Python 3 9 13```

enough-analyst-54434 · Answer

So bunch of Pythons

enough-analyst-54434 · Answer

You may be able to just ignore the errors and use that set of errors as your baseline assuming they are all because you don t have needed Pythons on the PATH for old Pants

enough-analyst-54434 · Answer

I personally use pyenv to install a bunch of Pythons on my machine but I think you need not do that to fix the issue you re trying to fix + add a test for that That test can probably just run against ~modernish Pants

bored-glass-58755 · Answer

Ok I thought to have the required python but digging thru <https github com pantsbuild setup blob gh pages github workflows ci yml L45|https github com pantsbuild setup blob gh pages github workflows ci yml L45> I figured it probably expects python 2 7 I d just rather ignore the errors

enough-analyst-54434 · Answer

SGTM in the end green CI is what matters and some way for you to write + run a new test

bored-glass-58755 · Answer

gt And that plays out like this <https github com pantsbuild setup runs 6712806317 check suite focus=true step 4 47|https github com pantsbuild setup runs 6712806317 check suite focus=true step 4 47> I just saw this and found out that it is exposing python 3 9 13 but I have 3 9 12 I can upgrade my minor version and try it once more before moving on to the real stuff

enough-analyst-54434 · Answer

The minor versions do not matter at all

enough-analyst-54434 · Answer

That s just the set of Pythons that happen to be available on Github runners That CI step just exposes all the pre installed Pythons that happen to be there

bored-glass-58755 · Answer

Ok gotcha I have never used GitHub CI so please pardon my ignorance there

enough-analyst-54434 · Answer

This code here <https github com pantsbuild actions blob main expose pythons action yml>

enough-analyst-54434 · Answer

No problem

bored-glass-58755 · Answer

Hi I have created the PR <https github com pantsbuild setup pull 127|https github com pantsbuild setup pull 127>

bored-glass-58755 · Answer

Hi < enough analyst 54434> I am getting following error in my CI on the line where it tries to extract all but `PEX ROOT` from the array `pex env vars` ` pants line 336 pex env vars unbound variable` This is happening when I am supplying no `PEX ` env variables at all in the CI and so it seems it is unable to extract anything out of an empty array This however doesn t throw any error when I try to run that small logic standalone in bash where I do not supply any `PEX ` variables This also doesn t fail the test case I wrote if I remove the `PEX ` environment variables from the test case Nonetheless I think we should introduce this small check just to make it more robust for all platforms environments `if $ pex env vars eq 0 then` What do you think

enough-analyst-54434 · Answer

Should I not read too much into the fact line 336 does not line up at all with the PR <https github com pantsbuild setup pull 127 files diff 2c50624bea38c570f59fb28e3fffd11330856e2cd512760acaff9eb82d3df8caR286>

enough-analyst-54434 · Answer

I do not repro in a dedicated test file ```jsirois Gill Windows ~$ cat test sh usr bin env bash set euo pipefail function scrub env vars Ensure the virtualenv PEX runs as shrink wrapped See local r pex env vars= $ PEX local r pex env vars to scrub= $ pex env vars PEX ROOT if n $ pex env vars to scrub then echo gt amp 2 Scrubbing $ pex env vars to scrub unset $ pex env vars to scrub fi Also ensure pip doesn t think packages on PYTHONPATH are already installed if n $ PYTHONPATH then echo gt amp 2 Scrubbing PYTHONPATH unset PYTHONPATH fi scrub env vars jsirois Gill Windows ~$ test sh jsirois Gill Windows ~$ echo $ 0 jsirois Gill Windows ~$ PEX FOO=bar PEX ROOT=baz test sh Scrubbing PEX FOO jsirois Gill Windows ~$ echo $ ``` Maybe this is a bash behavior difference based on version ```jsirois Gill Windows ~$ bash version GNU bash version 5 0 17 1 release x86 64 pc linux gnu Copyright C 2019 Free Software Foundation Inc License GPLv3+ GNU GPL version 3 or later lt gt This is free software you are free to change and redistribute it There is NO WARRANTY to the extent permitted by law ```

bored-glass-58755 · Answer

The error line was copied pasted from my CI output which would not match the script from PR because I have some extra `echo` lines in my CI Sorry for the confusion It is giving error on line 286 `local r pex env vars to scrub= $ pex env vars PEX ROOT `

enough-analyst-54434 · Answer

And what bash version in CI then

enough-analyst-54434 · Answer

Since I do not repro

enough-analyst-54434 · Answer

Maybe `local ar` read only array instead of `local r` read only The `= `form on the RHS is supposed to make the variable a Bash array implicitly but maybe this needs to be explicit in older versions of Bash Adding the ` a` works fine doesn t change anything in my version of Bash

bored-glass-58755 · Answer

This is the bash version in pipeline ```GNU bash version 4 2 46 2 release x86 64 redhat linux gnu ```

bored-glass-58755 · Answer

I was just thinking from the perspective of making the fix robust and so in my opinion adding a check wouldn t harm

enough-analyst-54434 · Answer

I just confirmed it is a Bash version difference ```jsirois Gill Windows ~$ mnt c Users John Sirois Downloads bash 4 2 bash test sh test sh line 9 pex env vars unbound variable```

enough-analyst-54434 · Answer

< bored glass 58755> I agree but I d also like to understand things Give me a sec longer to see if there is not a more kosher way to do this in old bash

enough-analyst-54434 · Answer

Ok this works with 4 2 0 and 5 0 17 ```local r pex env vars= $ PEX The explicit empty entry below avoids pex env vars being considered an unbound variable by older version of Bash when there are no PEX variables in the environment ```

bored-glass-58755 · Answer

Sounds good I will make the change and push it