https://pantsbuild.org/ logo
#general
Title
# general
c

curved-television-6568

09/12/2022, 1:19 AM
Well this was a gotcha for me, not being aware of this subsystem: https://www.pantsbuild.org/docs/reference-python-native-code I tried to set
CPPFLAGS
and
LDFLAGS
using https://www.pantsbuild.org/docs/reference-subprocess-environment#env_vars but it didn’t bite there not so obviously until I found the other dedicated subsystem for those particular env vars. Motivation for this subsystem?
e

enough-analyst-54434

09/12/2022, 1:33 AM
Some reading here where it was introduced: https://github.com/pantsbuild/pants/pull/5815 I think those concerns have diverged from the current reality, but worth reading anyhow.
👍 1
w

wide-midnight-78598

09/12/2022, 5:59 AM
Wow, I also didn't know about this subsystem - should probably come into the conversation re: naming cgo and cc flags https://github.com/pantsbuild/pants/discussions/16777
b

bitter-ability-32190

09/12/2022, 10:55 AM
I think we should take a holistic approach to env vars. Currently it's all scattered
2
(I could say that about subsystems as well 😛) Which, while I'm soapboxing, @hundreds-father-404 had an amazing idea to make subsystem options pluggable like target fields. Then say
python
backend could inject into
tailor
, instead of having to make its options only in its subsystem
c

curved-television-6568

09/12/2022, 3:22 PM
oh that would be awesome to have.
b

bitter-ability-32190

09/12/2022, 3:22 PM
I was gonna take a look after my very long arc of
fix
and targetless formatters/fixers 😛
h

hundreds-father-404

09/12/2022, 6:33 PM
This is one of our most poorly designed subsystems. It was added in 1.24 or something to unblock the v2 test runner, and it was before we had any knowledge about how we would want to do things with Pants v2. We never fixed the design https://github.com/pantsbuild/pants/issues/14612