high-yak-85899
09/28/2022, 5:27 PMhappy-kitchen-89482
09/28/2022, 5:28 PMhigh-yak-85899
09/28/2022, 5:31 PMpyscard<2.0.4
, then changed my requirements file to pyscard>2.0.4
but I'm not getting any notice about my lockfile needing an update.high-yak-85899
09/28/2022, 5:31 PMhigh-yak-85899
09/28/2022, 5:32 PMpyscard<2.0.4
in the lockfile metadatahappy-kitchen-89482
09/28/2022, 5:33 PMhigh-yak-85899
09/28/2022, 5:34 PMhigh-yak-85899
09/28/2022, 5:35 PMrequirements.txt
is ./pants test
in case that's relevant.high-yak-85899
09/28/2022, 5:36 PM./pants package
on something else and did not see different behavior just to make sure.high-yak-85899
09/28/2022, 5:48 PMrequirements.txt
, I still don't see any invalidation happen (double checked I didn't change [python].invalid_lockfile_behavior
)high-yak-85899
09/28/2022, 5:49 PMhigh-yak-85899
09/28/2022, 5:50 PMhundreds-father-404
09/28/2022, 5:50 PMIs it possible that the lockfile validation is only working with the subset of the lockfile/requirements needed for the goals I am running?Ahhhh, yeah that is it!
high-yak-85899
09/28/2022, 5:51 PMhappy-kitchen-89482
09/28/2022, 5:53 PMhappy-kitchen-89482
09/28/2022, 5:53 PMhundreds-father-404
09/28/2022, 5:55 PMAllTargets
to discover what goes into the lockfile. But honestly, that concern may be overblown: we already use AllTargets
for dep inferencehigh-yak-85899
09/28/2022, 5:55 PMyubikey-manager
. yubikey-manager
needs pyscard>=1.9,<3
. pyscard==2.0.4
has installation issues so we add an additional requirement of pyscard>2.0.4
. Running my test that uses yubikey-manager
does not trigger an invalid lockfile errorhundreds-father-404
09/28/2022, 5:56 PMhigh-yak-85899
09/28/2022, 5:57 PMhundreds-father-404
09/28/2022, 5:57 PMrequirements.pex
, but that gets cached. and they're agnostic to Pants the whole timehigh-yak-85899
09/28/2022, 6:01 PMrequirements.txt
.high-yak-85899
09/28/2022, 6:02 PMrequirements.txt
exactly match the metadata of my constraints.txt
happy-kitchen-89482
09/28/2022, 7:00 PMhigh-yak-85899
09/28/2022, 7:03 PMhigh-yak-85899
09/28/2022, 7:04 PMhigh-yak-85899
09/28/2022, 7:05 PMhigh-yak-85899
09/28/2022, 7:07 PMrequirements.txt
. There's no searching through all targets to find places where other python_requirement
targets have been called out. So I can ask my system the simple question like "does the metadata in the lockfile exactly match requirements.txt"happy-kitchen-89482
09/28/2022, 10:11 PMhundreds-father-404
09/28/2022, 10:53 PM