https://pantsbuild.org/ logo
#general
Title
# general
s

steep-waitress-53641

10/28/2022, 8:06 PM
Pants 2.14 minor issues of note 1. In build_ignore the escaping appears to have changed. I had to change
build_ignore = ['\\{\\{ cookiecutter.__repo_name \\}\\}']
to
build_ignore = ['\{\{ cookiecutter.__repo_name \}\}']
. 2. For sh tests that sourced the original sh file, I had to add the original sh file as an explicit dependency to the sh_tests section of the BUILD file. (ie if
lib/foo_test.sh
has a line like
source lib/foo.sh
I had to add
:lib
to the shunit2_tests dependencies. I'm actually not sure how this worked previously, since I had a different repo where I had the explicit dependency, although that used
source "$(dirname "${BASH_SOURCE[0]}")/foo.sh"
s

sparse-lifeguard-95737

10/28/2022, 8:07 PM
point 2 is https://github.com/pantsbuild/pants/issues/16949 - I was also surprised that it ever worked at all, but apparently there is dependency inference in the shell plugin! 😅
👍 1
h

happy-kitchen-89482

10/28/2022, 9:04 PM
Huh, not good that we released 2.14.x without fixing that, since we had that issue open for over a month.
Re 1, I didn’t even know we did escaping
@steep-waitress-53641 are you preprocessing your pants.toml or something? I don’t really know what that syntax is, or what would provide
cookiecutter.__repo_name
there
s

steep-waitress-53641

10/28/2022, 9:55 PM
Re 1: We have essentially a template for new repos using a tool called cookie cutter https://github.com/cookiecutter/cookiecutter
h

happy-kitchen-89482

10/28/2022, 11:49 PM
Hrm
and this is definitely due to upgrading to 2.14, rather than some issue with cookiecutter?
It would be instructive to see the differences between the finalized pants.toml (post cookie-cutter) in each case
s

steep-waitress-53641

10/29/2022, 12:07 AM
So this is the PR where I'm upgrading the cookie cutter template: https://github.com/grapl-security/buildkite-plugin-cookiecutter/pull/27/files
h

happy-kitchen-89482

10/29/2022, 12:51 AM
What is the end result, post-cookie-cutter, before and after?
4 Views