https://pantsbuild.org/ logo
Join Slack
Powered by
Besides the fact that I'm duplicating a lot of inf...
# general
s
Besides the fact that I'm duplicating a lot of information on 
pyproject.toml
and 
python_distribution
, any feedback on this https://github.com/Kludex/uvicorn-extensions?
c
haven’t looked extensively, but noticed a trailing 
/*
in your source roots. Maybe doesn’t do any harm, but not usually included there.. 🙂
oh, maybe I misread that, looking at your source tree, you expect to have each extension dir in your source roots, right? then the 
/*
is probably exactly what you should have..
s
the 
/*
was because of the 
tests
🤔
because I have 
from tests import ...
c
no, you have 
["/src/python/*", "/"]
, I was referring to the suffix on 
/src/python
… but nvm, looking at your source tree layout, it makes sense now 🙂
🙏 1
I would perhaps consider a macro to reduce the amount of boiler plate for the 
python_distribution
… but that can be done whenever 🙂
s
the macro cannot reduce somehow the 
pyproject.toml
, right? Just the 
python_distribution
(I'll do that 🙏)
c
yes, only BUILD file contents…
could consider a simple script that you can run that just updates the fixed parts of your pyproject.toml files so they are consistent, like author and constraints and the like…
but rarely used so I’m not sure if that’s motivated 😛
s
the "problem" is more about the duplication, rather than the effort on an "auto-update script"
c
yeah, that would just be to manage the duplication rather than getting rid of it
s
anything else?
(thanks btw)
🙏 1
c
120 lines of BUILD file data removed 👍
anything else?
nothing that stands out to me at this time.. 🙂
3 Views
Open in Slack
PreviousNext
Powered by