https://pantsbuild.org/ logo
#general
Title
# general
s

shy-advantage-49800

11/12/2022, 9:24 AM
Besides the fact that I'm duplicating a lot of information on
pyproject.toml
and
python_distribution
, any feedback on this https://github.com/Kludex/uvicorn-extensions?
c

curved-television-6568

11/12/2022, 1:02 PM
haven’t looked extensively, but noticed a trailing
/*
in your source roots. Maybe doesn’t do any harm, but not usually included there.. 🙂
oh, maybe I misread that, looking at your source tree, you expect to have each extension dir in your source roots, right? then the
/*
is probably exactly what you should have..
s

shy-advantage-49800

11/12/2022, 1:06 PM
the
/*
was because of the
tests
🤔
because I have
from tests import ...
c

curved-television-6568

11/12/2022, 1:10 PM
no, you have
["/src/python/*", "/"]
, I was referring to the suffix on
/src/python
… but nvm, looking at your source tree layout, it makes sense now 🙂
🙏 1
I would perhaps consider a macro to reduce the amount of boiler plate for the
python_distribution
… but that can be done whenever 🙂
s

shy-advantage-49800

11/12/2022, 1:13 PM
the macro cannot reduce somehow the
pyproject.toml
, right? Just the
python_distribution
(I'll do that 🙏)
c

curved-television-6568

11/12/2022, 1:13 PM
yes, only BUILD file contents…
could consider a simple script that you can run that just updates the fixed parts of your pyproject.toml files so they are consistent, like author and constraints and the like…
but rarely used so I’m not sure if that’s motivated 😛
s

shy-advantage-49800

11/12/2022, 1:15 PM
the "problem" is more about the duplication, rather than the effort on an "auto-update script"
c

curved-television-6568

11/12/2022, 1:16 PM
yeah, that would just be to manage the duplication rather than getting rid of it
s

shy-advantage-49800

11/12/2022, 1:19 PM
anything else?
(thanks btw)
🙏 1
c

curved-television-6568

11/12/2022, 3:47 PM
120 lines of BUILD file data removed 👍
anything else?
nothing that stands out to me at this time.. 🙂
3 Views