lemon-oxygen-7249811/15/2022, 9:08 AM
! I'm coming with an additional request 😉 I've tried pinning `pyright`'s version as follows in `pants.toml`:
But this isn't recognized:
[pyright] version = "pyright==1.1.258" lockfile = "pants_dir/3rdparty/pyright_lockfile.lock"
Am I doing something wrong or is the locking support missing? I need it because right now
→ PANTS_SHA=11b4fd412631c6315b474e49fe482dec1767cf29 ./pants check libs/geometry:: ... 10:00:25.71 [ERROR] Invalid option 'lockfile' under [pyright] in /home/churlin/dev/kaiko-eng/pants.toml 10:00:25.71 [ERROR] Invalid option 'version' under [pyright] in /home/churlin/dev/kaiko-eng/pants.toml 10:00:25.71 [ERROR] Invalid config entries detected. See log for details on which entries to update or remove.
pulls a different version of
than my regular CI and I get discrepancies 😕 I can create an issue if that would help you, let me know.
wide-midnight-7859811/15/2022, 1:18 PM
does not specify a version. In most Python tools, that comes with
I think we'll need a
, to match
Kinda makes me wish we had a more composable infra, in lieu of subclassing as much
subsystem, I think
and then setting:
version = StrOption( advanced=True, default=lambda cls: cls.default_version, help="Requirement string for the tool.", )
However, a more "correct" solution would be to apply some default Npx/Npm base subsystem which has some standard defaults setup, or maybe even a mixin.
process = await Get( Process, NpxProcess( npm_package=pyright.default_version,
lemon-oxygen-7249811/16/2022, 10:46 AM
wide-midnight-7859811/18/2022, 2:53 AM
PANTS_SHA=800d4bc94b38f6cea3b30b247c1d90186af8b426 ./pants --firstname.lastname@example.org help-advanced pyright `pyright` subsystem advanced options ------------------------------------ --pyright-version=<str> PANTS_PYRIGHT_VERSION version default: email@example.com current value: firstname.lastname@example.org (from command-line flag) overrode: email@example.com (from pants.toml) Version string for the tool in the form package@version (e.g. firstname.lastname@example.org)