I don t know if it s the way coverage py works or it s the p Pants #general

I don’t know if it’s the way coverage.py works or ...

refined-addition-53644

01/20/2023, 3:40 PM

I don’t know if it’s the way coverage.py works or it’s the pants integration but the coverage doesn’t include those modules which aren’t imported by the tests. I thought it would look at all the source files and then compare it with the tests inside the test files.

refined-addition-53644

01/20/2023, 3:43 PM

So if I don’t write any tests, the coverage would be 100%? 😄

refined-addition-53644

01/20/2023, 3:57 PM

I think it’s the issue with the pants integration. I ran it outside directly using coverage and it looks at all the source files under a provided directory.

happy-kitchen-89482

01/20/2023, 4:10 PM

Yeah, coverage expects to have a global view of all sources, which is at odds with the monorepo way of doing things incrementally (and also doesn't really scale).

happy-kitchen-89482

01/20/2023, 4:10 PM

We'd have to copy all the sources into the sandbox

refined-addition-53644

01/20/2023, 4:11 PM

I am actually filtering currently. So it should only copy all the source files inside these directories.

refined-addition-53644

01/20/2023, 4:44 PM

So what works is setting the

source

option inside the config file. I am using

pyproject.toml

. So I set

Copy code

[tool.coverage.run]
omit = ["*/tests/*"]
source = [
  "source1",
  "source2",
  "source3",
]

refined-addition-53644

01/20/2023, 6:26 PM

Actually I spoke too soon. This doesn’t work either. Not sure what’s going on since pants is also using

pytest --cov=source ..

when the filter option is provided. But the results don’t match with running pytest locally with

--cov

option. It does include all the source files inside the source directory. In case of pants that doesn’t happen.

2 Views

Open in Slack

Previous Next