Tried the new python-dump-source-analysis goal, and it doesn't understand use of env(). Bug? `InvalidFieldTypeException: The 'image_tags' field in target apps/_demo_app/docker:demo_app must be an iterable of strings (e.g. a list of strings), but was

['latest', None]

with type

list

.`

what if you give the env a default value?

env("NAME", "default")

I think we should err while having option to set default value? So if it’s

None

then we should err

(I may be in favour of the former, to fail early by default)

Even now I do this in python.

not directly.. https://github.com/pantsbuild/pants/blob/bd84dd98392a6d7289b2b8175cca39eafddb273e/src/python/pants/engine/internals/build_files.py#L226-L233 https://github.com/pantsbuild/pants/blob/bd84dd98392a6d7289b2b8175cca39eafddb273e/src/python/pants/engine/internals/parser.py#L148-L149

Indeed, the default value solved the issue. I probably always had run with the variable set. Thanks!

I have occasionally set an env var to an empty string on purpose. The only reason I think it should error is if the env var is not set at all. The semantics of

""

depend on the env var. So, if you didn’t want

""

you could do something like

(env("SOMETHING", "foo") or "foo")

I wonder if you could raise an error in a BUILD file… like

(env("SOMETHING", "default") or raise Exception("SOMETHING is an empty string!"))

Has anyone tried raising exceptions in BUILD files?

I recall there’s been a PR fixing support for raising/catching exceptions but don’t find it right now.