I am noticing what seems to be an issue with the r...
# general
f
I am noticing what seems to be an issue with the recent changes to
skip_push
on docker images. I have a number of intermediate packages organized something like the "optimize your docker builds" blog post that I can't seem to find right now. My
docker_image
targets are as follows: • python_base (base python dependency + some security stuff) • serviceA:srcs (COPY and unpack/precompile a sources pex) • serviceA:deps (COPY and unpack/precompile a dependencies pex) • serviceA:<real_tag_for_production> (COPY srcs and deps from the :srcs and :deps images) • # repeat for a number of services python_base and all have the :srcs and :deps images all have
skip_push=True
, since their only purpose is to be preliminary steps in a multistage build On my branch to upgrade to pants 2.33 (from 2.30) I am seeing that my CI publish script (which is basically just
pants publish src::
) has started failing because it is trying to publish all images that were packaged. I can write up an issue, but just wanted to ask around quick first.
w
Sorry for the trouble. 30 -> 33 is a fairly wide jump. Possible to narrow it by doing intermediate bumps 30 -> 31 -> 32?
f
no worries. Its definitely from 31 -> 32 that causes issues. (Agree with @ripe-architect-1001 below)
I created a bug report at github.com/pantsbuild/pants/issues/23621 with a workaround described
🙏 1
c
I have a number of intermediate packages organized something like the "optimize your docker builds" blog post that I can't seem to find right now.
https://www.pantsbuild.org/blog/2022/08/02/optimizing-python-docker-deploys-using-pants ?
🙏 1
f
That's the one
w
found the issue, working on a fix