<#23045 the hobgoblin of little minds comes for Ex...
# github-notifications
q
#23045 the hobgoblin of little minds comes for ExternalTool's default_known_versions Issue created by cburroughs I know it's a small thing, but this inconsistency drives me nuts. Sometimes we do (reverse lexicographic sort within each version)
Copy code
"2.41.3|macos_x86_64|ad200ce58db4a980b79a6cf182ae69e4b3ffc6f30af722396ba4dadaa54a535e|5735548",
        "2.41.3|macos_arm64|8f053cb9e01ffaa32b929dbf73d34f0a81d135044751f8d4138a418064ee5ae5|5370742",
        "2.41.3|linux_x86_64|22aa6d3bc2ec239d62d3d190bcb036a47f2b24e0c3c6edfccebb6a55fbb2078e|5642686",
        "2.41.3|linux_arm64|f20852f79109c8a77cb19150d26fc5c5a0d3bbde33bf46a76341e434ea411225|5174782",
And other times we sort:
Copy code
"1.9.0|linux_arm64|f5c0a49b482c008a6afd2248c08ca919e599c1154a850ff94809f4a85c86eb3b|24710285",
            "1.9.0|linux_x86_64|ab1358e73a81096bbe04201ef403a32e0765c5f6e360692d170d32d0889a4871|27010938",
            "1.9.0|macos_arm64|b7701c42a9b69524cfe79f0928d48ec4d648bc5e08794df12e8b41b56a0a395c|25718506",
            "1.9.0|macos_x86_64|b69196c831d6315b6e79178c96a66365d724cf4b922ad4a9763cd970aeeecd45|27940121",
And as another variant, sometimes the platform is fixed width:
Copy code
"v3.2.4|macos_arm64 |e70fc42e69debe3e400347d4f918630cdf4bf2537277d672bbc43490387508ec|2998546",
        "v3.2.4|macos_x86_64|43a0461a1b54070ddc04fbbf1b78f7861ee39a65a61f5466d15a39c4aba4f917|2980208",
        "v3.2.4|linux_arm64 |6474d9cc08a1c9fe2ef4be7a004951998e3067d46cf55a011ddd5ff7bfab3de6|2752512",
        "v3.2.4|linux_x86_64|3f5a47f8fec27fae3e06d611559a2063f5d27e4b9501171dde9959b8c60a3538|2797568",
(In all cases I check we are consistent with versions going from highest to lowest.) I don't think this is quite worth a linting rule, but I'd like to: • Codify ideal consistent behavior with
build-support/bin/external_tool
• Do a one time consistency pass. My proposal: • Lexicographic sort of platform • Fixed width platform: yes cc @grihabor pantsbuild/pants