Hey! Quick Q:
```Please run with `--plugins=hdrhis...
# generalh
hundreds-lion-13128
04/11/2025, 4:52 AMHey! Quick Q:
Copy code
Please run with `--plugins=hdrhistogram` if you would like histogram summaries to be shown at the end of the run, or permanently add `[GLOBAL].plugins = ['hdrhistogram']`. This will cause Pants to install the `hdrhistogram` dependency from PyPI.w
wide-midnight-78598
04/11/2025, 12:18 PMWhat command are you running?
wide-midnight-78598
04/11/2025, 12:19 PMIm guessing stats or stats-log or something?
f
fast-nail-55400
04/11/2025, 2:18 PMWe should just include it in the Pants internal lock file. I believe my attempt to do so was rejected when that support landed as being too many deps. But printing out that message still seems silly to me.
fast-nail-55400
04/11/2025, 2:19 PMOr make stats support be a backend and have hdrhistogram be a requirement of that “stats” backend.
w
wide-midnight-78598
04/11/2025, 2:21 PMYeah, the issue here is that we have a warning for something that should be mandatory
wide-midnight-78598
04/11/2025, 2:22 PMWe absolutely do have wayyyy too many deps, but the warning is incongruous with the solution/workaround
wide-midnight-78598
04/11/2025, 2:22 PM(for the message) Its the "if you would like" which could be changed, because you can't have a warning that asks if you want something.
Should either not be a warning, or should say "we expect" - and if we expect it, then we should just already have it
f
fast-nail-55400
04/11/2025, 5:24 PM> We absolutely do have wayyyy too many deps, but the warning is incongruous with the solution/workaround
I generally agree with the “too many deps” point, but would argue this dependency is a core part of the monitoring experience and so is justified.
b
broad-processor-92400
04/14/2025, 12:04 AMIn answering the original question, I believe one can silence specific warnings with https://www.pantsbuild.org/stable/reference/global-options#ignore_warnings
broad-processor-92400
04/14/2025, 1:14 AMRe hdrhistogram as an explicit dependency, I've filed https://github.com/pantsbuild/pants/issues/22189 and opened https://github.com/pantsbuild/pants/pull/22190
broad-processor-92400
04/14/2025, 8:50 PMThat PR is merged now and will work its way through the release pipeline to come out in 2.27.0, so thank you, Benny, for your contribution to Pants! Asking questions to prompt improvements!
h
hundreds-lion-13128
04/24/2025, 9:04 AMThanks a lot all! I think this is certainly a better situation. I think either removing the message, or adding the dep would be good.
8 Views