I'm trying to run pants from source and having a R...
# generalf
fierce-fall-70380
02/03/2025, 2:40 PMI'm trying to run pants from source and having a Rust-related issue. 🧵
fierce-fall-70380
02/03/2025, 2:40 PM Copy code
Compiling engine v0.0.1 (/Users/acam/pants/pants/src/rust/engine)
error: unexpected `cfg` condition value: `gil-refs`
--> src/externs/mod.rs:61:1
|
61 | create_exception!(native_engine, EngineError, PyException);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: expected values for `feature` are: `default` and `extension-module`
= help: consider adding `gil-refs` as a feature in `Cargo.toml`
= note: see <<https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html>> for more information about checking conditional configuration
= note: `-D unexpected-cfgs` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unexpected_cfgs)]`
= note: this error originates in the macro `$crate::impl_exception_boilerplate` which comes from the expansion of the macro `create_exception` (in Nightly builds, run with -Z macro-backtrace for more info)w
wide-midnight-78598
02/03/2025, 2:45 PMDo you have all the correct deps?
https://www.pantsbuild.org/stable/docs/contributions/development/setting-up-pants#step-2-bootstrap-the-rust-engine
Also, that might need to say python 3.11 now, rather than 3.9
f
fierce-fall-70380
02/03/2025, 2:49 PMSo I tried this:
Copy code
--- a/src/rust/engine/Cargo.toml
+++ b/src/rust/engine/Cargo.toml
@@ -294,8 +294,8 @@ prodash = { git = "<https://github.com/stuhood/prodash>", rev = "stuhood/raw-messa
prost = "0.13"
prost-build = "0.13"
prost-types = "0.13"
-pyo3 = "0.22"
-pyo3-build-config = "0.22"
+pyo3 = "0.23.4"
+pyo3-build-config = "0.23.4" Copy code
error: use of deprecated trait `pyo3::ToPyObject`: `ToPyObject` is going to be replaced by `IntoPyObject`. See the migration guide (<https://pyo3.rs/v0.23.0/migration>) for more information.
--> src/externs/mod.rs:14:26
|
14 | use pyo3::{FromPyObject, ToPyObject};
| ^^^^^^^^^^fierce-fall-70380
02/03/2025, 2:49 PMAlso, that might need to say python 3.11 now, rather than 3.9Oh, I had to do
brew install python@3.9w
wide-midnight-78598
02/03/2025, 2:50 PMUnless you're editing rust code, you shouldn't need to change anything.
Did you pull from
mainf
fierce-fall-70380
02/03/2025, 2:50 PMLet me review that link you provided though and make sure I have the right versions of everything.
fierce-fall-70380
02/03/2025, 2:50 PMI pulled from
mainw
wide-midnight-78598
02/03/2025, 2:51 PMAh, okay, so I think that's still python 3.9 - and an older Rust - but should still work
wide-midnight-78598
02/03/2025, 2:52 PMUnless the lock is auto-upgrading or something?
f
fierce-fall-70380
02/03/2025, 2:52 PMI have the latest Rust installed (1.84.1) -- should that be ok or do I need an older version?
w
wide-midnight-78598
02/03/2025, 2:54 PMIt uses 1.82.0 - but if you run
pants --version👍 1
f
fierce-fall-70380
02/03/2025, 2:54 PMOk, so I just checked
mainfierce-fall-70380
02/03/2025, 2:55 PMThat should be fine. I'm trying to debug an issue with the ambiguity resolution of python dep infer.
w
wide-midnight-78598
02/03/2025, 2:55 PMYeah, when in doubt, I recommend always building vanilla off main - changes can always be cherry picked back
f
fierce-fall-70380
02/03/2025, 2:56 PMThanks!
👍 1
f
fast-nail-55400
02/03/2025, 4:01 PM[Side note: PyO3 underwent several API changes from 0.22 -> 0.23. Merely upgrading 0.22 -> 0.23 will fail unless those source changes are made, which of course we made those changes on the
main7 Views