brave-garage-48416
10/08/2024, 8:54 AMresult = await Get(
Process,
NodeJSToolRequest,
subsystem.request(
args=tuple(
[
.....
]
),
input_digest=digest,
description="",
level=LogLevel.DEBUG,
extra_env=env,
),
)
process = InteractiveProcess.from_process(result)
when trying to return this process in a PublishProcesses result I'm hitting this issue. Is it possible to go around it somehow? I've tested passing in the PATH as extra envs but the NodeJSTool chain overwrites the PATH env variablefast-nail-55400
10/09/2024, 2:40 PMPATH instead of overwriting.fast-nail-55400
10/09/2024, 2:40 PMfast-nail-55400
10/09/2024, 2:42 PMPATh being overwritten. That logic was modified to allow the user to configure prepending or appending the additional elements to PATH. See https://github.com/pantsbuild/pants/pull/21185 as one of the PRs.fast-nail-55400
10/09/2024, 2:43 PMprepare_env_vars function at https://github.com/pantsbuild/pants/blob/0b7ba6ea5afd1084f6d86d487bf77c9b10a403e2/src/python/pants/core/util_rules/adhoc_process_support.py#L780 for the actual merge logic.fast-nail-55400
10/09/2024, 2:44 PMprepare_env_vars is actually generic enough that you could likely reuse it in the nodejs rules.brave-garage-48416
10/09/2024, 2:50 PM