elegant-florist-94385
10/02/2024, 11:18 AMpackage ::
would fail on first error and a developer would have to fix errors one by one, then wait on CI to see the next error.
Curious what other thoughts are, and some insights from practical experience.straight-alligator-6122
10/02/2024, 1:30 PMelegant-florist-94385
10/02/2024, 4:45 PM--changed-since
(based on the warning in https://www.pantsbuild.org/2.21/docs/using-pants/using-pants-in-ci#approach-1-only-run-over-changed-files) and on prior history. Our monorepo isn't THAT big that linting everything in one go is too prohibitive.
Some questions I have about --changed-since
though: How would this affect coverage reporting on tests. It seems you wouldn't be able to get an accuracte coverage report this waygorgeous-winter-99296
10/02/2024, 9:42 PM--changed-since
is when we publish containers. We unconditionally package them, though. You can see I do some manual sharding based on resolve for package, since we parametrize our whole codebase on resolves. For hot caches it doesn't matter much, but on full cache invalidations it does shave a few minutes.
Looking at some timings, our CI is <10 minutes minute E2E including publishing container images (one being 10G ML bullshit), 10-15 with cold local caches, and 15-20 minutes for a full cache invalidation.
This is a fairly typical view when I look at CI timings for our main Pants repo.