I’m trying out the new docker buildx support and s...
# general
f
I’m trying out the new docker buildx support and seeing an issue with the
docker.docker-info.json
that is produced. Its missing the image_id that used to be included, is that expected? https://www.pantsbuild.org/2.19/docs/docker/tagging-docker-images#retrieving-the-tags-of-an-packaged-image
Copy code
{
  "version": 1,
  "image_id": "<unknown>",
  "registries": [
    {
      "alias": null,
      "address": "[redacted]",
      "repository": "my_app",
      "tags": [
        {
          "template": "latest",
          "tag": "latest",
          "uses_local_alias": false,
          "name": "[redacted]/my_app:latest"
        }
      ]
    }
  ]
}
This is local on a mac M1 with the containerd storage enabled per the docs
b
sorry for the trouble! I think the image ID is extracted by parsing the docker build output, so potentially the output in your configuration has changed and the parsing needs to be updated. Could you file a bug and include the output of a docker build outside pants and/or with https://www.pantsbuild.org/2.19/reference/subsystems/docker#build_verbose turned on?
f
opened an issue here https://github.com/pantsbuild/pants/issues/20520 I think its just missing an additional regex for the new stdout format
👍 1
Looks like buildx broke my original fix https://github.com/pantsbuild/pants/issues/20686
b
Ah, good catch. There's now a top level
[docker].use_buildx
option, so we could do a double solution: • if buildx is enabled, use
--iidfile
• if not, keep augmenting the regexes
f
Its unclear to me if
--iidfile
would be 100% reliable though. Combinations like
buildx
but not
containerd-snapshotter
would likely run into issues https://github.com/docker/buildx/issues/1712
b
Oh, that's disappointing. Thanks for finding it... I guess we just need to keep augmenting the regexes