curved-manchester-66006
11/20/2023, 4:10 PMenv.FOO syntax being depreciated and:
10:35:44.98 [WARN] DEPRECATED: pants.backend.helm.target_types.HelmDeploymentValuesField.format_with() is scheduled to be removed in version 2.19.0.dev0.
==> /home/ecsb/.cache/nce/65aa4f2a6c1f9bac672c0df94ae34c7170e5c071cda35e9b725945831905c122/bindings/venvs/2.18.0/lib/python3.9/site-packages/pants/util/memo.py:123
return memoized_results[key]
result = func(*args, **kwargs)
memoized_results[key] = result
But as far as I can tell this repo is not using that syntax anywhere. (I tried upgrading to 2.19.0a0 past the deprecationion and things work so I think I'm right about that.) I'm also confused about "when" the message appears. It shows up "sometimes", but not reliably if I run pants --no-local-cache --no-pantsdcurved-television-6568
11/20/2023, 6:12 PMbroad-processor-92400
11/20/2023, 6:57 PMcurved-manchester-66006
11/20/2023, 7:27 PMbroad-processor-92400
11/20/2023, 11:25 PMbroad-processor-92400
11/20/2023, 11:52 PMvalues field on helm_deployment at all? If so, can you give some examples of what's in them? I can reproduce the first warning about format_with but not the one about {env.X} when there's no subtitutionbroad-processor-92400
11/20/2023, 11:57 PMcurved-manchester-66006
11/21/2023, 3:53 AMvalues is in use, here are a few lightly edited deployments
helm_deployment(
name="prerequisites-localdev",
release_name="prerequisites",
sources=["prerequisites-common-values.yaml"],
chart="//3rdparty/chart/datahub:datahub-prerequisites",
)
helm_deployment(
name="datahub-localdev",
release_name="datahub",
sources=["common-values.yaml"],
values={
"datahub-frontend.ingress.hosts[0].host": f"datahub-localdev-{env('LOCALDEV_SIGIL', env('USER', 'john-hancock'))}.<http://dev.corp.io|dev.corp.io>",
},
chart="//3rdparty/chart/datahub:datahub",
)
helm_deployment(
name="deploy-localdev",
release_name="cron-ingest-rds",
values={
"image": "projects/corp_datahub/ingest/rds:rds-ingester",
# Set as needed for testing, but try not to walk away for the day with
# them constantly running
"cron_schedule": "7 * * * *",
"profiling_cron_schedule": "7 0 * * *",
},
sources=["values.yaml"],
chart="./chart:chart",
)
Re goals, I got it for list and fmt fix lint check all togetherbroad-processor-92400
11/21/2023, 4:18 AMbroad-processor-92400
11/21/2023, 4:38 AM