Is anyone else interested in the nfpm backend (whi...
# pluginsp
proud-dentist-22844
11/09/2023, 6:55 PMIs anyone else interested in the nfpm backend (which can build rpm, deb, apk, archlinux packages)? Interested enough to help with it?
Here is the plugin: https://github.com/pantsbuild/pants/pull/19308
👀 2
proud-dentist-22844
11/09/2023, 6:55 PMI really need to go back to other work priorities, so I won't have time to write tests for awhile. I would love some help if anyone has time to spare.
I didn't feel I could write tests while I was exploring and thrashing around to figure out what all the plugin needed to do. I focused on the UX and writing extensive help_texts for each field/target to make sure using them made sense (answering questions like: should this be a field? Should it be a target? Should it be inferred somehow?)
Now, however, I think the plugin is conceptually complete. So, writing tests to safeguard it for future refactors and changes makes a lot of sense. I'm sad I ran out of time to do this right now though 😞. I really want to get it into pants.
c
curved-television-6568
11/09/2023, 10:27 PMI assigned myself on review, as I anticipate using this feature in the not too distant future. As such I’m willing to dive in and get familiar with the code, and writing tests may actually be a perfect way of doing that. Not sure what pace I’ll be able to keep up, but I’ll keep at it to see this through with you. Thanks for the huge amount of work done so far.
❤️ 1
p
proud-dentist-22844
11/09/2023, 10:28 PMThank you! Anything you can do would be a big help!
proud-dentist-22844
11/09/2023, 10:28 PMFeel free to push to the same branch
👍 1