Hi, does 2.17 have any breaking changes for custom...
# generalc
curved-policeman-2796
08/30/2023, 5:59 PMHi, does 2.17 have any breaking changes for custom plugins? Running
pants Copy code
File "[snip]/site-packages/pants/backend/python/subsystems/python_tool_base.py", line 211, in default_lockfile_url
assert cls.default_lockfile_resource is not None
AssertionErrorcurved-policeman-2796
08/30/2023, 6:00 PMUntitled
c
curved-television-6568
08/30/2023, 6:06 PMunfortunate that the assert didn’t include details about which class it was..
curved-television-6568
08/30/2023, 6:06 PMdoes your plugin register any custom python tools?
e
enough-analyst-54434
08/30/2023, 6:39 PMLooks like the short answer is yes, here: https://github.com/pantsbuild/pants/commit/02b66572aedcdf31d3e168ce63e4f58239bfce87
That went out in 2.17.0a0.
c
curved-policeman-2796
08/30/2023, 7:25 PMThanks both - I will take a look.
curved-policeman-2796
08/30/2023, 7:26 PMunfortunate that the assert didn’t include details about which class it wasluckily we only have one custom tool so I think I know the culprit
curved-policeman-2796
08/30/2023, 7:43 PMThanks, it turned out to be a one-liner. Just adding
Copy code
default_lockfile_resource = ("package-name", "whatever.lock")PythonToolBase👍 1
c
curved-television-6568
08/30/2023, 7:58 PMThe
default_lockfile_resourcePythonToolBase2 Views