https://pantsbuild.org/ logo
Join Slack
Powered by
Pants 2.17.0rc4 is now available! To upgrade, set...
# announce
h
Pants 2.17.0rc4 is now available! To upgrade, set pants_version="2.17.0rc4" in the [GLOBAL] section of your pants.toml. We hope to make this the 2.17.0 stable release, so please do test it out in your repos. Thanks to all the contributors to this release!
šŸŽ‰ 2
šŸš€ 2
šŸ‘– 3
āœ… 1
b
https://github.com/komprenilo/liga/pull/163 Just upgraded to 2.17.0rc4, works fine
g
Found a few issues: ā€¢ The 
check
goal is suddenly not enabled in our repo so 
pants check ::
fails ā€¢ Dependency-inference is failing to pick up a package (
torch
) if we only do 
from ...
imports (!) ā€¢ We have a few weird warnings about unowned dependencies in a 
pex_binary
with a parametrized resolve that don't exist in 2.16
Will try to blow out the caches, but... "base case"
Copy code
# decimate.py
from torch.utils.tensorboard import SummaryWriter
Copy code
āœ¦ āÆ pants peek cmd/decimate.py@resolve=cpu
[
  {
    "address": "cmd/decimate.py@resolve=cpu",
    "target_type": "python_source",
    "dependencies": [
      "//:cpu#coloredlogs",
      "//:cpu#tensorboard",
      "src/py/cliclasses/cliclasses/__init__.py@resolve=cpu"
    ],
    ...
But if I add a direct dependency...
Copy code
# decimate.py
from torch.utils.tensorboard import SummaryWriter
import torch
Copy code
āœ¦ āÆ pants peek cmd/decimate.py@resolve=cpu
14:50:14.20 [WARN] Pants cannot infer owners for the following imports in the target cmd/decimate.py@resolve=cpu:

  * tensorboard.backend.event_processing.event_accumulator (line: 20)
  * tensorboard.compat.proto.summary_pb2.HistogramProto (line: 22)
  * tensorboard.compat.proto.summary_pb2.Summary (line: 22)
  * tensorboard.compat.proto.types_pb2 (line: 21)

If you do not expect an import to be inferrable, add `# pants: no-infer-dep` to the import line. Otherwise, see <https://www.pantsbuild.org/v2.17/docs/troubleshooting#import-errors-and-missing-dependencies> for common problems.
[
  {
    "address": "cmd/decimate.py@resolve=cpu",
    "target_type": "python_source",
    "dependencies": [
      "//:cpu#coloredlogs",
      "//:cpu#tensorboard",
      "//:torch-cpu",
      "src/py/cliclasses/cliclasses/__init__.py@resolve=cpu"
    ],
I wonder if something with 
tensorboard
here is tripping up the dependency inference thinking the two packages are related...
Clearing caches seems to have no effect. Going back to 2.16 fixes both issues. Repros both with and without 
use_rust_parser
.
b
Can you make a reproduction repo?
g
Working on it!
b
šŸ™
h
@bitter-ability-32190 sounds like we need another 2.17.x RC?
b
Unfortunately
h
Let me know when it's ready to be cut
b
Merged
h
I'll kick off that last rc
fingers crossed that the CI fixes hold
b
I'm always optimistic
h
b
We're green
5 Views
Open in Slack
PreviousNext
Powered by