blue-city-97042
08/18/2023, 3:02 PM# After this version, Pants is released as a per-platform PEX using GitHub Release assets.
# See <https://github.com/pantsbuild/pants/pull/19450>
PANTS_PEX_GITHUB_RELEASE_VERSION = Version("2.18.0.dev5")
Further inspection of the code shows this in the install_pants.py:
def install_pants_from_pex(
venv_dir: Path,
prompt: str,
version: Version,
ptex: Ptex,
extra_requirements: Iterable[str],
find_links: str | None,
) -> None:
"""Installs Pants into the venv using the platform-specific pre-built PEX."""
uname = os.uname()
major, minor = sys.version_info[:2]
pex_name = f"pants.cp{major}{minor}-{uname.sysname.lower()}_{uname.machine.lower()}.pex"
with tempfile.NamedTemporaryFile(suffix=".pex") as pants_pex:
pex_url = (
f"<https://github.com/pantsbuild/pants/releases/download/release_{version}/{pex_name}>"
)
Where this is called if the release has hit the 2.18... version. Since this is not templitized nor overridable, this will cause issues related to systems where the binary must be hosted by internal servers. Is this something that can be resolved prior the drop dead release?bitter-ability-32190
08/18/2023, 3:10 PMblue-city-97042
08/18/2023, 3:10 PMbitter-ability-32190
08/18/2023, 3:10 PMbitter-ability-32190
08/18/2023, 3:10 PMbitter-ability-32190
08/18/2023, 3:10 PMblue-city-97042
08/18/2023, 3:12 PMblue-city-97042
08/18/2023, 3:12 PMblue-city-97042
08/18/2023, 3:12 PMbitter-ability-32190
08/18/2023, 3:13 PM