Hey, Any chance someone can review this PR? On a different matter, I’m seeing an unexpected behavior when running

pants --no-pantsd --no-watch-filesystem --changed-dependents=transitive --changed-since=<commit-sha> publish

I have two packages, X and Y, where X consumes Y (

python_sources()

of Y is declared as a dependency in the

python_sources()

of X). I also have a custom plugin that intercepts usages of

python_artifact

(as part of

python_distribution

) When I run the command, although only X changed, I see my plugin runs on both X and Y. Is that intentional? (I think the

package

step runs on both, while

publish

only runs on X) Thanks!!

Well, I can imagine that Y's

python_artifact()

would get evaluated as part of BUILD file parsing, even if it doesn't end up being published. Do you see anything beyond that happening?

My plugin code is being run, which surprises me Can it be because the version is being calculated as part of

python_distribution

?

Ah, right

any recommendations? can I somehow tell if a module I am calculating the version for will be published?

Hmm, I can't think of a way to detect this inside your custom python_artifact()

I’m calculating the next version, and creating a git tag with that version I’ll provide an example: X uses Y only X is changed, but when setup.py is generated for X, it needs to know the version of Y. Since my script handles fetching the next version, it returns a version for Y that will not be published (it will have a tag tho)

I see

Thanks. Opened https://github.com/pantsbuild/pants/issues/19509