Good morning. Documentation typo found on (<https...
# generalc
cool-account-59189
06/30/2023, 2:47 PMGood morning. Documentation typo found on (https://www.pantsbuild.org/docs/using-pants-in-ci#tip-store-pants-logs-as-artifacts)
cool-account-59189
06/30/2023, 2:47 PMThe line:
We recommend that you configure your CI system to store the pants log (Should read:) as a build artifact, so that it is available in case you need to troubleshoot CI issues..pantsd.d/pants.log
We recommend that you configure your CI system to store the pants log (i.e. there are too many "d" s in the path) as a build artifact, so that it is available in case you need to troubleshoot CI issues..pants.d/pants.log
e
enough-analyst-54434
06/30/2023, 2:48 PMYou can fix here if you're game: https://github.com/pantsbuild/pants/blob/main/docs/markdown/Using%20Pants/using-pants-in-ci.md
c
cool-account-59189
06/30/2023, 2:49 PMOh! alright...well I will do that here in a bit then. Thanks John.
cool-account-59189
07/13/2023, 3:44 PM@enough-analyst-54434: Yeah this has been a minute, but is there a naming convention I should use for the branch off of main for the documentation update? and whom should I put on the review? (is there a page documenting the development process)....
e
enough-analyst-54434
07/21/2023, 8:12 PMYou should fork the pants repo and create the PR using your fork. At that point the branch name is only in your fork and the convention is up to you. I will note a pro-tip for OSS repos hosted on github / gitlab, etc -> don't trust / look for contribution docs - docs lie: just look at recent PRs! If the project is somewhat sane, the PRs should exhibit what is expected.
enough-analyst-54434
07/21/2023, 8:19 PMAs for who to put on the review - git blame is my tool of choice. Recent editors of the file and / or looking at the edit PRs to see who reviewed those. Another trick that works across OSS projects.
2 Views