Just had a very tedious incident caused by a missi...
# generala
average-breakfast-91545
05/10/2023, 3:57 PMJust had a very tedious incident caused by a missing file in a pex_binary. There was a warning, can't find an owner for an import, but the package built and deployed. Am I missing a way to make that fail the build? ignore_errors isn't set to True anywhere that I can see.
c
curved-television-6568
05/10/2023, 4:08 PMyea, the default is to warn, you may want it to error: https://www.pantsbuild.org/v2.16/docs/reference-python-infer#unowned_dependency_behavior
❤️ 1
a
average-breakfast-91545
05/10/2023, 4:08 PMThanks!
c
curved-television-6568
05/10/2023, 4:09 PMwe think error is the sane thing to do, but it’s warn due to being backwards compatible for when the option didn’t exist, IIRC
a
average-breakfast-91545
05/10/2023, 4:09 PMI googled around, but it was sort of hard to find the exact place in the docs where that info is recorded
➕ 1
c
curved-television-6568
05/10/2023, 4:10 PMmight be a good time to revisit that default value.
curved-television-6568
05/10/2023, 4:11 PMsorry you had to learn this the hard way
a
average-breakfast-91545
05/10/2023, 4:12 PMNo bother! I was just confused about whether I'd done this to myself
average-breakfast-91545
05/10/2023, 4:12 PMI low key love Pants, so my tolerance for the unexpected is high
❤️ 6
h
happy-kitchen-89482
05/10/2023, 5:25 PMWe could deprecate the default - we can detect if you're relying on it and warn that you must set it explicitly to continue to get that behavior
happy-kitchen-89482
05/10/2023, 5:26 PMIt's probably time
a
average-breakfast-91545
05/10/2023, 5:26 PMAs in flip the default and provide a useful error if there's no value set?
average-breakfast-91545
05/10/2023, 5:27 PMThat sounds like a PR within my limited capabilities.
❤️ 3
b
busy-vase-39202
05/10/2023, 6:00 PMCool! We love it having new contributors. ❤️
h
happy-kitchen-89482
05/10/2023, 6:59 PMWell, this would be a two-parter. Part one - use our deprecation mechanism to warn you if you're relying on the default. The warning would state that in, say, 2.18.0.dev0 the default will switch. Then, after we cut the 2.17.x release branch, a second PR will change the default and remove the warning.
happy-kitchen-89482
05/10/2023, 7:01 PMFor the first part, you can use is_default() to check if the value is being provided by the default (it's not enough to check the value, because that could have been explicitly set to the same as the default), and the warning should state that you must set it explicitly if you want to continue to use that value.
happy-kitchen-89482
05/10/2023, 7:01 PMWe'd love a PR!
a
average-breakfast-91545
05/10/2023, 7:02 PMMight do this as a warmup before I try and tackle excluding transitive deps.
👍 1
🙏 1
b
busy-vase-39202
05/10/2023, 7:12 PMHave fun! Reach out if you run into trouble. Maintainers are happy to help.