#18899 2.0.17.dev4 Has errors with target names when --changed-dependees=transitive package is used Issue created by snazzer Describe the bug Seeing failures like:

Engine traceback:
  in `package` goal

InvalidTargetNameError: The target name ../tests (defined in directory iai_coral_api/flg_tests/agents/test_rest.py) contains banned characters (`/`). Please replace these characters with another separator character like `_` or `-`.

When the command is something like

./pants --changed-since=origin/develop --changed-dependees=transitive package

Removing

--changed -dependees=transitive

will allow the command to proceed. It doesn't matter what the goal is, the failure will still occur so long as

--changed -dependees=transitive

is present. As a clue, the tests directories in my situation use a recursive glob. The problems seems to be mitigated if I use BUILD files for every directory, but I'd rather not have to do that since a single file is easier to manage. Example BUILD in the test directory

python_tests(
    name="tests",
    sources=[
       'test*.py',
       '**/test*.py',
    ],
    dependencies=[
       'iai_coral_api:dist',
       ':test_utils',
    ],
    skip_mypy=True,
    skip_flake8=True,
)

python_test_utils(
   name="test_utils",
   sources=[
      'mock_auth.py',
      'utils.py'
   ],
   skip_mypy=True,
    skip_flake8=True,
)

Pants version 2.0.17.dev4 OS Both OSX and Linux pantsbuild/pants