Hey team. Any support for running Go analyzers as...
# generall
lively-garden-66504
04/06/2023, 9:54 PMHey team. Any support for running Go analyzers as part of
checkcompilef
fast-nail-55400
04/06/2023, 10:00 PMEnable the applicable backends and they will run during the
lint👀 1
fast-nail-55400
04/06/2023, 10:01 PMPants supports the golangci_lint linter
fast-nail-55400
04/06/2023, 10:01 PMpants.backend.experimental.go.lint.golangci_lint❤️ 1
fast-nail-55400
04/06/2023, 10:02 PMif there are other linters you want in Pants, it is straightforward to add lint plugins. we would welcome contributions there.
l
lively-garden-66504
04/06/2023, 10:03 PMNice nice, just what I was hoping for. Do you know if it still supports incrementalism?
f
fast-nail-55400
04/06/2023, 10:04 PMI am not sure I understand the question. What program supports "incrementalism"?
fast-nail-55400
04/06/2023, 10:05 PMDo you mean Pants or golangci_lint?
l
lively-garden-66504
04/06/2023, 10:05 PMJust the goal I guess. I recall MyPy isn't incremental
f
fast-nail-55400
04/06/2023, 10:06 PMBy "incremental", do you mean that the linter only flags errors in new code?
fast-nail-55400
04/06/2023, 10:09 PMRegarding the
lint😢 1
l
lively-garden-66504
04/06/2023, 10:48 PMAh that's unfortunate. Yeah I was hoping it had the same incremental behavior that golangci-lint itself has
lively-garden-66504
04/06/2023, 10:48 PMAt least you can run
./pants lint --changed-sincef
fast-nail-55400
04/07/2023, 7:00 AMYes --changed-since should work. Also the
lintfast-nail-55400
04/07/2023, 7:01 AMBut I am not familiar enough with golangci_lint to know if any "incremental" behavior specific to that tool works with Pants. I suggest trying and see if it does work. If not, file an issue so at least we know there is something to fix.
4 Views