That's the home for things you run while developing or releasing Pants

Hey, where do I put the dependencies? there isn't a

python_requirements

in the "/build_support/bin"? I added one and had to regenerate the root lockfile, which didn't seem right?

You can put them in 3rdparty/python/requirements.txt

Dependency inference will pull in just the dependencies that are actually needed

So requirements.txt is really just a list of potential dependencies, rather than a recipe for creating a venv that always includes all of them

That's true in general in Pants-enabled repos, not just in its own repo

ok, sounds good, thanks!

ok, hopefully last thing. I've got it crawling and fetching all versions and packing them in the format. What's the last step for how to make this work? Do I print it to screen and we copypaste as required? Do I dump to TOML and load in the terraform plugin? The copypaste option is the easiest, but requires a manual step and can't be included in CI. OTOH, it's like 95% of the way there. Thoughts?

I think this is something we'd want to run manually anyway, at least at first

And copy-paste into the source

that would be a very good start

Should we instead bump the default version? If that's a more sensible default, sounds good to me. cc @fast-nail-55400

The simplest would probably be to just bump the default version. Pants has checksums like this for downloads in several places, and past practice has just been to have a default version. If the user wants a different version, they have to update the known checksums on their own.

I still believe we should revisit how tools are setup. The tool definition would be better as a target type. At the very least, that would lead to a more intuitive way for users to define the tool than is currently provided.

As the current way of doing it, requires calculating the checksum manually and then formulating the string with

|

-separated fields which is not even close to intuitive.

Terraform is a bit different though

Since the client version is embedded in the data it generates

so tighter control on the version is needed

And offering a range of known versions that are easy to switch between is probably really useful

oh true

Heh, so, this req is actually because I thought it was a bit klunky to switch to a newer TF, with that packed-string field. [this change](https://github.com/pantsbuild/pants/pull/15950) which just got merged adds a codec for encoding/decoding to the known_versions packed string, so it's at least easier to generate them. I'm not sure how much of a hurdle it would be to accept a Union[str, ExternalToolVersion] for that field (or to drop the str altogether, breaking backwards compatibility). I've got another partially-baked change that scrapes all of the known_versions for TF. I think having the known_versions defined and easy to switch to is a nice feature. We should probably omit the versions of TF we won't support (alphas, ancient versions).

breaking backwards compatibility).

Plugin API is not stable, so it's "legal". Although where possible, we try to be good citizens and properly deprecate plugin stuff Generally, we're trying to get our APIs right before we stabilize, even though that is a worse short-term experience

I’m trying to write a plugin in our repo to run

msgfmt

on

.po

files (trying to replicate Django’s

compilemessages

management command), but I’m having trouble getting my

rule

to be recognized by

export-codegen

. Details in 🧵

Hello, I’m getting this dependency resolution error when trying to generate-lockfiles - 🧵

10:26:19.01 [ERROR] 1 Exception encountered:

  ProcessExecutionFailure: Process 'Generate lockfile for python-default' failed with exit code 1.
stdout:

stderr:
ERROR: Could not find a version that satisfies the requirement pantsbuild.pants.testutil<2.13,>=2.12.0a0
ERROR: No matching distribution found for pantsbuild.pants.testutil<2.13,>=2.12.0a0

I just tried upgrading to 2.13.0a1 from 2.12.0 and now I need to upgrade my plugins. 🙂 First off, this change feels significant with lots of stuff to wade through: https://github.com/pantsbuild/pants/pull/15538 AddressSpecs and DescendantAddresses were replaced, but I'm not quite sure with what. Using

SpecsWithoutFileOwners

doesn't sound right, so, what is the new way to do this:

all_expanded_targets = await Get(Targets, AddressSpecs([DescendantAddresses("")]))

Ultimately I need to get a list of all targets in the repo that have my extension's field https://github.com/st2sandbox/st2/blob/pants/pants-plugins/stevedore_extensions/python_dependency_injection.py#L58-L61

Trying to implement an

ExportRequest

union type and I'm just getting an error about

ExportVenvsRequest

which is a bit confusing. source: https://github.com/xlevus/gymkhana-timer/blob/61c5e4c9d2bb622b85bf71bb3a84ad7480a56dbb/pants-plugins/upants/goals/export_upython_package.py

Exception caught: (builtins.ValueError)
  File "/home/xlevus/.cache/pants/setup/bootstrap-Linux-x86_64/2.11.0_py39/bin/pants", line 8, in <module>
    sys.exit(main())
  File "/home/xlevus/.cache/pants/setup/bootstrap-Linux-x86_64/2.11.0_py39/lib/python3.9/site-packages/pants/bin/pants_loader.py", line 115, in main
    PantsLoader.main()
  File "/home/xlevus/.cache/pants/setup/bootstrap-Linux-x86_64/2.11.0_py39/lib/python3.9/site-packages/pants/bin/pants_loader.py", line 111, in main
    cls.run_default_entrypoint()
  File "/home/xlevus/.cache/pants/setup/bootstrap-Linux-x86_64/2.11.0_py39/lib/python3.9/site-packages/pants/bin/pants_loader.py", line 93, in run_default_entrypoint
    exit_code = runner.run(start_time)
  File "/home/xlevus/.cache/pants/setup/bootstrap-Linux-x86_64/2.11.0_py39/lib/python3.9/site-packages/pants/bin/pants_runner.py", line 99, in run
    runner = LocalPantsRunner.create(
  File "/home/xlevus/.cache/pants/setup/bootstrap-Linux-x86_64/2.11.0_py39/lib/python3.9/site-packages/pants/bin/local_pants_runner.py", line 148, in create
    graph_session = cls._init_graph_session(
  File "/home/xlevus/.cache/pants/setup/bootstrap-Linux-x86_64/2.11.0_py39/lib/python3.9/site-packages/pants/bin/local_pants_runner.py", line 78, in _init_graph_session
    scheduler = EngineInitializer.setup_graph(
  File "/home/xlevus/.cache/pants/setup/bootstrap-Linux-x86_64/2.11.0_py39/lib/python3.9/site-packages/pants/init/engine_initializer.py", line 185, in setup_graph
    return EngineInitializer.setup_graph_extended(
  File "/home/xlevus/.cache/pants/setup/bootstrap-Linux-x86_64/2.11.0_py39/lib/python3.9/site-packages/pants/init/engine_initializer.py", line 309, in setup_graph_extended
    scheduler = Scheduler(
  File "/home/xlevus/.cache/pants/setup/bootstrap-Linux-x86_64/2.11.0_py39/lib/python3.9/site-packages/pants/engine/internals/scheduler.py", line 212, in __init__
    self._py_scheduler = native_engine.scheduler_create(

Exception message: Encountered 4 rule graph errors:
  No installed rules return the type ExportVenvsRequest, and it was not provided by potential callers of @rule(pants.backend.python.goals.export:135:export_virtualenvs(ExportVenvsRequest, PythonSetup, DistDir) -> ExportResults, gets=[Get(ExportResult, _ExportVenvRequest)]).
    If that type should be computed by a rule, ensure that that rule is installed.
    If it should be provided by a caller, ensure that it is included in any relevant Query or Get.
  No source of dependency DistDir for @rule(pants.backend.python.goals.export:135:export_virtualenvs(ExportVenvsRequest, PythonSetup, DistDir) -> ExportResults, gets=[Get(ExportResult, _ExportVenvRequest)]). All potential sources were eliminated: []
  No source of dependency Get(ExportResult, _ExportVenvRequest) for @rule(pants.backend.python.goals.export:135:export_virtualenvs(ExportVenvsRequest, PythonSetup, DistDir) -> ExportResults, gets=[Get(ExportResult, _ExportVenvRequest)]). All potential sources were eliminated: []
  No source of dependency PythonSetup for @rule(pants.backend.python.goals.export:135:export_virtualenvs(ExportVenvsRequest, PythonSetup, DistDir) -> ExportResults, gets=[Get(ExportResult, _ExportVenvRequest)]). All potential sources were eliminated: []
NoneType: None

(cross-post) https://pantsbuild.slack.com/archives/C0D7TNJHL/p1657017938531779

is it possible to “extend” dependency inference for a custom target type? i.e. I’m considering making a custom target for Django

apps.py

files, to replicate the dependency rules that Django uses for pulling in models/migrations/templates etc. Our

apps.py

files are mostly lightweight, but a few import some 3rd-party libraries. wondering if I could implement a dependency-inference rule for

MyCustomDjangoAppsTarget

, and within the rule do something like

cast(PythonSourceTarget, my_custom_target)

, use that to run the “default” dependency inference for python code, then tack on the extra django-specific dependencies

E       ValueError: Encountered 3 rule graph errors:
E         No installed rules return the type WrappedTargetRequest, and it was not provided by potential callers of @rule(pants.engine.internals.graph:327:resolve_target(WrappedTargetRequest, TargetTypesToGenerateTargetsRequests) -> WrappedTarget, gets=[Get(_TargetParametrizations, _TargetParametrizationsRequest)]).
E           If that type should be computed by a rule, ensure that that rule is installed.
E           If it should be provided by a caller, ensure that it is included in any relevant Query or Get.
E         No source of dependency Get(_TargetParametrizations, _TargetParametrizationsRequest) for @rule(pants.engine.internals.graph:327:resolve_target(WrappedTargetRequest, TargetTypesToGenerateTargetsRequests) -> WrappedTarget, gets=[Get(_TargetParametrizations, _TargetParametrizationsRequest)]). All potential sources were eliminated: []
E         No source of dependency TargetTypesToGenerateTargetsRequests for @rule(pants.engine.internals.graph:327:resolve_target(WrappedTargetRequest, TargetTypesToGenerateTargetsRequests) -> WrappedTarget, gets=[Get(_TargetParametrizations, _TargetParametrizationsRequest)]). All potential sources were eliminated: []

any ideas on what rule need to be put into RuleRunner to satisfy this rule graph error?

pants.engine.internals.graph

is already listed.

Hey folks, I was trying to understand how the helm target types pull in all their files. I think it's not working correctly though, I'm getting

[INFO] values.yaml: file does not exist
[WARNING] templates/: directory not found

but they're definitely there (created with a

helm init foo

, and

helm lint foo

works fine). I think those files should be pulled in through a sourcesfield [here](https://github.com/pantsbuild/pants/blob/5430176e16bf68b2cc291698036ddca182cf0769/src/python/pants/backend/helm/target_types.py#L109) Can someone confirm that the helm plugin is working, it should be working with just

helm_chart()

in the BUILD file and I shouldn't need to add anything? Or those files aren't pulled in automatically and it's more like docker, where I need to add a dependency on a

file

target? This is working directly out of source files on this commit, 2.14.0.dev1